From 4c796906f579fc0be97b6f1022de218c31820971 Mon Sep 17 00:00:00 2001 From: HirazawaUi <695097494plus@gmail.com> Date: Tue, 6 Feb 2024 22:05:21 +0800 Subject: [PATCH 1/2] promote kep 4396 into implementable --- .../README.md | 6 ++++-- .../kep.yaml | 5 +++-- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/keps/sig-node/4369-allow-special-characters-environment-variable/README.md b/keps/sig-node/4369-allow-special-characters-environment-variable/README.md index 925ad5ed6d7..dde81657d1c 100644 --- a/keps/sig-node/4369-allow-special-characters-environment-variable/README.md +++ b/keps/sig-node/4369-allow-special-characters-environment-variable/README.md @@ -169,10 +169,12 @@ These tests will be added: - Solicit feedback from the Alpha. - Ensure tests are stable and passing. +- Add monitor for pods that fail due to using enhancements. #### GA -- No issues reported during two releases. +- Ensure that the time range of the beta version can cover the version skew of all components. +- Add troubleshooting details on how to deal with incompatible kubelet/CRI implementations based on issues found in beta releases. ### Upgrade / Downgrade Strategy @@ -240,7 +242,7 @@ No. ### Monitoring Requirements -- N/A +- We will investigate in the beta version how to monitor kubelet/CRI implementations could fail on pods using this enhancement. ### Dependencies diff --git a/keps/sig-node/4369-allow-special-characters-environment-variable/kep.yaml b/keps/sig-node/4369-allow-special-characters-environment-variable/kep.yaml index fb00a48989b..fce298b93db 100644 --- a/keps/sig-node/4369-allow-special-characters-environment-variable/kep.yaml +++ b/keps/sig-node/4369-allow-special-characters-environment-variable/kep.yaml @@ -5,12 +5,11 @@ authors: owning-sig: sig-node participating-sigs: - sig-api-machinery -status: provisional +status: implementable creation-date: 2023-12-21 reviewers: - "@liggitt" - "@thockin" - - TBD approvers: - "@liggitt" - "@thockin" @@ -29,6 +28,8 @@ latest-milestone: "v1.30" # The milestone at which this feature was, or is targeted to be, at each stage. milestone: alpha: "v1.30" + beta: "v1.32" + stable: "v1.36" # The following PRR answers are required at alpha release # List the feature gate name and the components for which it must be enabled From 904ce4dce350036bbbcee931b7d5516195ac99d9 Mon Sep 17 00:00:00 2001 From: HirazawaUi <695097494plus@gmail.com> Date: Sun, 4 Feb 2024 22:53:04 +0800 Subject: [PATCH 2/2] trigger PRR for kep 4369 --- keps/prod-readiness/sig-node/4369.yaml | 6 ++++++ 1 file changed, 6 insertions(+) create mode 100644 keps/prod-readiness/sig-node/4369.yaml diff --git a/keps/prod-readiness/sig-node/4369.yaml b/keps/prod-readiness/sig-node/4369.yaml new file mode 100644 index 00000000000..19a461e52b8 --- /dev/null +++ b/keps/prod-readiness/sig-node/4369.yaml @@ -0,0 +1,6 @@ +# The KEP must have an approver from the +# "prod-readiness-approvers" group +# of http://git.k8s.io/enhancements/OWNERS_ALIASES +kep-number: 4369 +alpha: + approver: "@jpbetz" \ No newline at end of file