Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KEP: Topology-aware service routing #640

Merged
merged 1 commit into from Dec 8, 2018

Conversation

@m1093782566
Copy link
Member

commented Dec 3, 2018

@m1093782566

This comment has been minimized.

Copy link
Member Author

commented Dec 3, 2018

/assign @jbeda

@wojtek-t wojtek-t self-assigned this Dec 3, 2018

@johnbelamaric

This comment has been minimized.

Copy link
Contributor

commented Dec 3, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Dec 3, 2018

@m1093782566

This comment has been minimized.

Copy link
Member Author

commented Dec 4, 2018

@idvoretskyi
Copy link
Member

left a comment

/lgtm

/hold

@m1093782566

This comment has been minimized.

Copy link
Member Author

commented Dec 6, 2018

@thockin

Can you confirm that if we can merge this PR? I think we all defer to you.

@thockin
Copy link
Member

left a comment

/lgtm
/approve

We will need to revisit the use of PodLocator in kube-proxy before going beta.

We need to figure out if PodLocator is a CRD or a built-in. I think we should do CRD. @saad-ali can offer guidance on linked-in CRDs.

As for apigroup, let's start with topology.k8s.io but I doubt that is going to last past alpha. We'll have to discuss more broadly once we know it works well.

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Dec 7, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: idvoretskyi, johnbelamaric, m1093782566, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@m1093782566

This comment has been minimized.

Copy link
Member Author

commented Dec 8, 2018

@thockin Okay, and thanks for your patient guidance.

@idvoretskyi Would you please cancel the hold now? :)

@justaugustus

This comment has been minimized.

Copy link
Member

commented Dec 8, 2018

/hold cancel

@k8s-ci-robot k8s-ci-robot merged commit 588e217 into kubernetes:master Dec 8, 2018

2 checks passed

cla/linuxfoundation m1093782566 authorized
Details
tide In merge pool.
Details

@m1093782566 m1093782566 referenced this pull request Jan 7, 2019

Open

Topology aware routing of services #536

0 of 1 task complete
@Yiming-Jia

This comment has been minimized.

Copy link

commented Mar 20, 2019

@m1093782566 Hi Jun, do you know which version of Kubernetes will include this change? We'd like to have this topology routing feature in our service.

@m1093782566

This comment has been minimized.

Copy link
Member Author

commented Mar 20, 2019

I think we target v1.15. I am working on it and hopefully will raise a PR in one or two weeks.

@krmayankk

This comment has been minimized.

Copy link
Contributor

commented Mar 21, 2019

@m1093782566 do you need help with any portions of it . If you want to divide this into small chunks let me know and I am happy to help

@m1093782566

This comment has been minimized.

Copy link
Member Author

commented Mar 21, 2019

Thanks @krmayankk

I will let you know once I need your help.

@Yiming-Jia

This comment has been minimized.

Copy link

commented Mar 22, 2019

@m1093782566 Hey Jun, do you know the release schedule for 1.15? Because this feature exactly solve a problem we're facing. We'd like to keep following the release schedule for this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.