Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update KEP template #690

Closed
wants to merge 1 commit into from

Conversation

@pwittrock
Copy link
Member

pwittrock commented Jan 15, 2019

  • Add release checklist
  • Expand upon graduation criteria
  • Add test plan section
  • Add upgrade / downgrade section
  • Add version skew section
Update KEP template
- Add release checklist
- Expand upon graduation criteria
- Add test plan section
- Add upgrade / downgrade section
- Add version skew section
@pwittrock

This comment has been minimized.

Copy link
Member Author

pwittrock commented Jan 15, 2019

/assign @spiffxp

@pwittrock

This comment has been minimized.

Copy link
Member Author

pwittrock commented Jan 15, 2019

/assign @justaugustus

@pwittrock

This comment has been minimized.

Copy link
Member Author

pwittrock commented Jan 15, 2019

@pwittrock

This comment has been minimized.

Copy link
Member Author

pwittrock commented Jan 15, 2019

@pwittrock

This comment has been minimized.

Copy link
Member Author

pwittrock commented Jan 15, 2019

/assign @calebamiles

@pwittrock

This comment has been minimized.

Copy link
Member Author

pwittrock commented Jan 17, 2019

/ping

@pwittrock pwittrock closed this Jan 19, 2019

@pwittrock

This comment has been minimized.

Copy link
Member Author

pwittrock commented Jan 19, 2019

closing per discussion with @calebamiles

@calebamiles

This comment has been minimized.

Copy link
Member

calebamiles commented Jan 19, 2019

/reopen
/approve

My mistake. We agreed in SIG Arch to iterate on this content on the PR. I'm personally of the opinion that we should wait until the next release for these requirements but I defer to the wisdom of the Release Team Lead.

@k8s-ci-robot k8s-ci-robot reopened this Jan 19, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 19, 2019

@calebamiles: Reopened this PR.

In response to this:

/reopen
/approve

My mistake. We agreed in SIG Arch to iterate on this content on the PR. I'm personally of the opinion that we should wait until the next release for these requirements but I defer to the wisdom of the Release Team Lead.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 19, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: calebamiles, pwittrock

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spiffxp

This comment has been minimized.

Copy link
Member

spiffxp commented Jan 19, 2019

/hold
I would like to make sure we've had sufficient discussion and review on both the content, and the impacts of this as it pertains to the use of https://github.com/calebamiles/keps/tree/master/helpers/convert

(ref: #619 and kubernetes/community#2725)

@justaugustus

This comment has been minimized.

Copy link
Member

justaugustus commented Jan 19, 2019

Closing in favor of #703 (so I can carry the PR updates, instead of @pwittrock).
/close

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 19, 2019

@justaugustus: Closed this PR.

In response to this:

Closing in favor of #703 (so I can carry the PR updates, instead of @pwittrock).
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.