Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubernetes-csi release process #807

Merged
merged 6 commits into from Sep 10, 2019

Conversation

@pohly
Copy link
Contributor

pohly commented Feb 4, 2019

This gets added as a KEP because the proposed solution will have to run on CNCF resources (Prow) and publish to the same destination as core Kubernetes (gcr.io). However, this proposal is independent of any particular Kubernetes release and thus does not need to be tracked.

/sig storage
/cc @msau42

Producing a combined release of all components no longer is a
goal. Instead, each component gets released independently and CSI
driver developers put together a combined deployment, similar to the
example in the csi-driver-host-path repo.
@pohly

This comment has been minimized.

Copy link
Contributor Author

pohly commented Feb 14, 2019

@msau42 I've updated the KEP - no more combined release, "rc" tags explicitly mentioned, etc.

Getting images published isn't supported well (or at all) in Prow at the moment, but it looks like there is a trick that is sufficient to test in a kind cluster, so I could start to implement this.

@pohly

This comment has been minimized.

Copy link
Contributor Author

pohly commented Feb 19, 2019

@msau42 updated once more.

Do we need to find reviewers from other SIGs?

This addresses the latest review feedback.
@pohly pohly force-pushed the pohly:kubernetes-csi-release branch from dbaa3b2 to b4837fa Feb 19, 2019
@msau42

This comment has been minimized.

Copy link
Member

msau42 commented Feb 19, 2019

We should get another reviewer from sig-testing to make sure we can do the image pushing to gcr.io with Prow. @kubernetes/sig-testing-pr-reviews

Next round of review feedback updates.
@msau42

This comment has been minimized.

Copy link
Member

msau42 commented Feb 21, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Feb 21, 2019
pohly added a commit to pohly/csi-driver-host-path that referenced this pull request Feb 26, 2019
prow.sh is a generic script that does unit and E2E testing inside a
Prow job.

xref: kubernetes/enhancements#807
pohly added a commit to pohly/test-infra that referenced this pull request Feb 26, 2019
This job is part of the plan for switching the kubernetes-csi release
process from Travis CI to Prow.

xref: kubernetes/enhancements#807
xref: kubernetes-csi/csi-driver-host-path#16
pohly added a commit to pohly/csi-driver-host-path that referenced this pull request Mar 7, 2019
prow.sh is a generic script that does unit and E2E testing inside a
Prow job.

xref: kubernetes/enhancements#807
pohly added a commit to pohly/csi-driver-host-path that referenced this pull request Mar 8, 2019
prow.sh is a generic script that does unit and E2E testing inside a
Prow job.

xref: kubernetes/enhancements#807
pohly added a commit to pohly/csi-driver-host-path that referenced this pull request Mar 8, 2019
prow.sh is a generic script that does unit and E2E testing inside a
Prow job.

xref: kubernetes/enhancements#807
pohly added a commit to pohly/csi-driver-host-path that referenced this pull request Mar 8, 2019
prow.sh is a generic script that does unit and E2E testing inside a
Prow job.

xref: kubernetes/enhancements#807
kzmrv added a commit to kzmrv/test-infra that referenced this pull request Mar 12, 2019
This job is part of the plan for switching the kubernetes-csi release
process from Travis CI to Prow.

xref: kubernetes/enhancements#807
xref: kubernetes-csi/csi-driver-host-path#16
pohly added a commit to pohly/test-infra that referenced this pull request Mar 13, 2019
We are in the process of enabling Prow testing for several repos in
the kubernetes-csi
organization (kubernetes/enhancements#807,
kubernetes#11715).

Instead of enabling the /test trigger individually for just the repos
where it works and then remember to update it when adding new ones, it
is simpler to just enable it for the entire org.
pohly added a commit to pohly/csi-driver-host-path that referenced this pull request Mar 15, 2019
prow.sh is a generic script that does unit and E2E testing inside a
Prow job.

xref: kubernetes/enhancements#807
pohly added a commit to pohly/csi-driver-host-path that referenced this pull request Mar 26, 2019
prow.sh is a generic script that does unit and E2E testing inside a
Prow job.

xref: kubernetes/enhancements#807

This separates which kind of tests to run (serial/parallel,
stable/alpha) from specifying what those tests are. Regular
expressions for choosing tests only need to be specified once now, the
actual focus and skip options are derived from that.

Merging all junit files into one while throwing away the tests that
we are not interested in increases load times in Spyglass. The
implementation in Go is not as fancy as a XLST style sheet or an
XPath-based filtering tool, but has the advantage that it works
without introducing additional dependencies.

csi-sanity testing is useful for CSI drivers.

There's no longer a need to explicitly provide a configuration and
deployment for the Kubernetes version that is being used for testing.
Instead, the "latest" settings and deployment are used as fallback.
@justaugustus

This comment has been minimized.

Copy link
Member

justaugustus commented May 26, 2019

/remove-sig architecture pm

@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented Aug 24, 2019

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@pohly

This comment has been minimized.

Copy link
Contributor Author

pohly commented Sep 4, 2019

/remove-lifecycle stale

@msau42

This comment has been minimized.

Copy link
Member

msau42 commented Sep 9, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Sep 9, 2019
Copy link
Member

saad-ali left a comment

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot removed the lgtm label Sep 10, 2019
- "@msau42"
- "sig-testing: TBD"
- "sig-release: TBD"
editor: "@pohly"
creation-date: 2019-02-04
last-updated: 2019-02-04
status: provisional

This comment has been minimized.

Copy link
@msau42

msau42 Sep 10, 2019

Member

is it implementable/implemented?

This comment has been minimized.

Copy link
@pohly

pohly Sep 10, 2019

Author Contributor

I think "provisional" is more suitable. The text should be updated once more to accommodate the latest proposal for image publishing from Prow (which just came in and is still pending in Kubernetes itself: kubernetes/test-infra#13332 (comment)); then it can be marked "implementable".

@msau42

This comment has been minimized.

Copy link
Member

msau42 commented Sep 10, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Sep 10, 2019
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Sep 10, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msau42, pohly, saad-ali

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit aad892e into kubernetes:master Sep 10, 2019
2 of 3 checks passed
2 of 3 checks passed
tide Not mergeable. Needs lgtm label.
Details
cla/linuxfoundation pohly authorized
Details
pull-enhancements-verify Job succeeded.
Details
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.