Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Configurable scale velocity for HPA #883
Hi @gliush. Thanks for your PR.
I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with
Once the patch is verified, the new status will be reflected by the
I understand the commands that are listed here.
This was referenced
Mar 7, 2019
referenced this pull request
Apr 2, 2019
@josephburnett: changing LGTM is restricted to assignees, and only kubernetes/enhancements repo collaborators may be assigned issues.
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing
a couple notes for clarity:
A KEP should not be a full API review, so it seems appropriate that this merge without that final approval. It would be bad if the ultimate API was radically different than what is in the KEP, but the reality is that APIs almost always evolve as they are implemented :)
thockin left a comment
Mostly API comments to sort through as you finalize the UX. This is a complicated API, so I'll encourage you to seek out simplifications, even at the cost of some flexibility. We can always add stuff, but removing is very hard.