Skip to content

Conversation

@sebgoa
Copy link
Contributor

@sebgoa sebgoa commented May 19, 2017

This a copy of the the kubernetes/kubernetes /examples directory
Keeping the history intact.

It moves all current examples into a /staging directory to prepare for a cleanup .

sebgoa and others added 30 commits November 17, 2016 16:49
trusted storage pool from which persistent gluster volume
has to be provided.

This patch introduce a new storage class parameter which allows
the admin to specify storage pool/cluster if required.

Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
…mages. Exposed most of the important Cassandra production tunables, and made the run.sh script a little easier to debug
Automatic merge from submit-queue

Update gluster setup readme.

Referring gluster setup guide to official glusterfs documentation. 

Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
Automatic merge from submit-queue

Remove a few versioned-warnings that snuck in, again
Automatic merge from submit-queue

Clean up some wording

The wording felt a little clunky so I tried to smooth it out a little. Hopefully I maintained the author's intent.
Automatic merge from submit-queue

Fix notice in redis-slave example
Automatic merge from submit-queue

Update Stateful Set example files for 1.5

1. Remove initialized annotation from statefulset examples
2. Update storage class annotation to beta in statefulset examples
3. Remove alpha limitation on PetSet in cassandra example

cc @erictune @foxish @kow3ns @enisoc @chrislovecnm @kubernetes/sig-apps

```release-note
NONE
```
Automatic merge from submit-queue

Add `clusterid`, an optional parameter to storageclass.

At present, admin doesn't have the privilege to chose the
trusted storage pool from which persistent gluster volume
has to be provided.

This patch introduce a new storage class parameter which allows
the admin to specify storage pool/cluster if required.

Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
Signed-off-by: Michael Adam <obnox@redhat.com>
Automatic merge from submit-queue

Reuse fields and labels

This should significantly reduce memory allocations in apiserver in large cluster.
Explanation:
- every kubelet is refreshing watch every 5-10 minutes (this generally is not causing relist - it just renews watch)
- that means, in 5000-node cluster, we are issuing ~10 watches per second
- since we don't have "watch heartbets", the watch is issued from previously received resourceVersion
- to make some assumption, let's assume pods are evenly spread across pods, and writes for them are evenly spread - that means, that a given kubelet is interested in 1 per 5000 pod changes
- with that assumption, each watch, has to process 2500 (on average) previous watch events
- for each of such even, we are currently computing fields.

This PR is fixing this problem.
Automatic merge from submit-queue (batch tested with PRs 37692, 37785, 37647, 37941, 37856)

fix scheduler extender example

<!--  Thanks for sending a pull request!  Here are some tips for you:
1. If this is your first time, read our contributor guidelines https://github.com/kubernetes/kubernetes/blob/master/CONTRIBUTING.md and developer guide https://github.com/kubernetes/kubernetes/blob/master/docs/devel/development.md
2. If you want *faster* PR reviews, read how: https://github.com/kubernetes/kubernetes/blob/master/docs/devel/faster_reviews.md
3. Follow the instructions for writing a release note: https://github.com/kubernetes/kubernetes/blob/master/docs/devel/pull-requests.md#release-notes
-->

**What this PR does / why we need it**:

Fix scheduler extender example , refer to [kubernetes/plugin/pkg/scheduler/api/types.go](https://github.com/kubernetes/kubernetes/blob/master/plugin/pkg/scheduler/api/types.go)

Thanks!
**Special notes for your reviewer**:

**Release note**:
<!--  Steps to write your release note:
1. Use the release-note-* labels to set the release note state (if you have access) 
2. Enter your extended release note in the below block; leaving it blank means using the PR title as the release note. If no release note is required, just write `NONE`. 
-->
```release-note
```
…om-registry

Automatic merge from submit-queue

Cut genericapserver->registry dependency

Towards moving genericapiserver into staging.
Automatic merge from submit-queue

Implement GID security for the GlusterFS dynamic provisioner.

<!--  Thanks for sending a pull request!  Here are some tips for you:
1. If this is your first time, read our contributor guidelines https://github.com/kubernetes/kubernetes/blob/master/CONTRIBUTING.md and developer guide https://github.com/kubernetes/kubernetes/blob/master/docs/devel/development.md
2. If you want *faster* PR reviews, read how: https://github.com/kubernetes/kubernetes/blob/master/docs/devel/faster_reviews.md
3. Follow the instructions for writing a release note: https://github.com/kubernetes/kubernetes/blob/master/docs/devel/pull-requests.md#release-notes
-->

**What this PR does / why we need it**:

This PR implements GID security for the glusterfs dynamic provisioner.
It is a reworked version of PR #37549 .

<!--
**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #

**Special notes for your reviewer**:
-->

**Release note**:

<!--  Steps to write your release note:
1. Use the release-note-* labels to set the release note state (if you have access) 
2. Enter your extended release note in the below block; leaving it blank means using the PR title as the release note. If no release note is required, just write `NONE`. 
-->
```release-note
The glusterfs dynamic volume provisioner will now choose a unique GID for new persistent volumes from a range that can be configured in the storage class with the "gidMin" and "gidMax" parameters. The default range is 2000 - 4294967295 (max uint32).
```
This removes all dependencies on Config during cert generation, only operating
on ServerRunOptions. This way we get rid of the repeated call of Config.Complete
and cleanly stratify the GenericApiServer bootstrapping.
Kubernetes Submit Queue and others added 9 commits May 15, 2017 09:45
Automatic merge from submit-queue

Fix the outdated link to the Helm Charts repo

**What this PR does / why we need it**:

It is only a link fix, the repo URL has changed

**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #

**Special notes for your reviewer**:

**Release note**:

```release-note
```
Automatic merge from submit-queue (batch tested with PRs 45826, 45747, 45548, 45606, 41766)

fixed typo in cockroachdb-statefulset.yaml

**What this PR does / why we need it**:

typo, the syntax was invalid.

**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #

**Special notes for your reviewer**:

**Release note**:

```release-note
```
The `bind 0.0.0.0` rule should end up in the sentinel config, not the script output.
Automatic merge from submit-queue (batch tested with PRs 45884, 45879, 45912, 45444, 45874)

Update Minio example

**What this PR does / why we need it**:
Added examples for Minio standalone and distributed modes

**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: 
- Add latest image tag in Minio image.
- Remove command and use args instead, inline with latest change in Minio. 

**Release note**:

```
Updates Minio server deployment example.
```
Automatic merge from submit-queue (batch tested with PRs 45884, 45879, 45912, 45444, 45874)

fix: typo in redis example

**What this PR does / why we need it**: The `bind 0.0.0.0` rule should end up in the sentinel config, not the script output.

**Special notes for your reviewer**:

**Release note**:

```release-note
```
bumped cassandra to v3.10, as v3.9 is no longer on the mirrors
bumped ubuntu-slim to v0.9
Automatic merge from submit-queue (batch tested with PRs 45852, 45965, 45941)

Examples: fixed cassandra mirror detection that assumes an FTP site will always be presented

**What this PR does / why we need it**:
This fixes regressions in the cassandra example docker image creation scripts

**Which issue this PR fixes** : #45882

**Special notes for your reviewer**:
Pound that accept button, it will be fine.

**Release note**:

```
Fixed the cassandra docker image cassandra mirror detection logic
bumped cassandra to v3.10, as v3.9 is no longer on the mirrors
bumped ubuntu-slim to v0.9
```
Automatic merge from submit-queue (batch tested with PRs 45990, 45544, 45745, 45742, 45678)

Add explicit image tag to cockroachdb example and test

@gyliu513 

```release-note
NONE
```
@sebgoa
Copy link
Contributor Author

sebgoa commented May 19, 2017

@ahmetb @bgrant0607

checking who I need to properly @mention: @kubernetes/sig-contributor-experience-misc

I think we need to get this merged quickly, and head over to the main repo to do the redirects.

@k8s-ci-robot
Copy link
Contributor

@sebgoa: These labels do not exist in this repository: sig/contributor-experience.

In response to this:

@ahmetb @bgrant0607

checking who I need to properly @mention: @kubernetes/sig-contributor-experience-misc

I think we need to get this merged quickly, and head over to the main repo to do the redirects.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

1 similar comment
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label May 19, 2017
@sebgoa
Copy link
Contributor Author

sebgoa commented May 19, 2017

not sure why the CLA check is failing here, I have signed it at least twice.

@cblecker
Copy link
Member

The CLA is failing due to many commits from many authors here.

@sebgoa
Copy link
Contributor Author

sebgoa commented May 19, 2017

ok, in agreement with Brian, the history is preserved from the original kubernetes/examples ...

@ahmetb
Copy link
Member

ahmetb commented May 22, 2017

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 22, 2017
@bgrant0607
Copy link
Member

Thanks for maintaining the history. If something looks wrong, we can always nuke it and start over, but it will be easiest to check after this is merged.

Yes, CLA bots aren't expected to deal with this, much like bulk cherrypicks into release branches. The original commits were verified to be covered by the CLA.

Merging.

@bgrant0607 bgrant0607 merged commit 9acf541 into kubernetes:master May 22, 2017
@bgrant0607
Copy link
Member

Confirmed that "blame" worked on a couple of the files.

Note that git history works but github PR history won't show the earlier PRs.

dims added a commit to dims/examples that referenced this pull request Aug 3, 2018
oops kubernetes#2

Change-Id: Ief434608f87afeb956a471ae35217b106a763739
@liggitt
Copy link
Member

liggitt commented Jul 25, 2019

It moves all current examples into a /staging directory to prepare for a cleanup .

is the cleanup still planned? https://github.com/kubernetes/kubernetes/pull/80356/files is attempting to update links to things in this subfolder folder, but I'm not sure why it exists

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.