New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change of labels from deployment documentation #3030

Closed
mikalstill opened this Issue Sep 3, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@mikalstill

mikalstill commented Sep 3, 2018

What keywords did you search in NGINX Ingress controller issues before filing this one? (If you have found any duplicates, you should instead reply there.):

"label"


NGINX Ingress controller version: github trunk

Kubernetes version (use kubectl version): v1.11.1

Environment: ubuntu 16.04

  • Cloud provider or hardware configuration: baremetal
  • OS (e.g. from /etc/os-release): 16.04.5 LTS (Xenial Xerus)
  • Kernel (e.g. uname -a): 4.15.0-30-generic
  • Install tools: wget and kubectl
  • Others:

What happened: followed the deployment instructions, validating the installation fails

What you expected to happen: I expected the labels to be correct in the validation step

How to reproduce it (as minimally and precisely as possible): install according to the docs

Anything else we need to know:

git commit 0a88be3 changed the labels that the mandatory.yaml file uses, but the deploy instructions at https://github.com/kubernetes/ingress-nginx/blob/master/docs/deploy/index.md still have you search for the old labels when validating the install.

@mikalstill

This comment has been minimized.

Show comment
Hide comment
@mikalstill

mikalstill Sep 3, 2018

Actually, there seems to be a fix pending (with no associated issue) at #3001

mikalstill commented Sep 3, 2018

Actually, there seems to be a fix pending (with no associated issue) at #3001

@aledbf

This comment has been minimized.

Show comment
Hide comment
@aledbf

aledbf Sep 5, 2018

Member

Closing. Fixed in #3035

Member

aledbf commented Sep 5, 2018

Closing. Fixed in #3035

@aledbf aledbf closed this Sep 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment