/ingress-nginx

Add support for custom proxy headers using a ConfigMap #246

Merged
merged 3 commits into from Feb 16, 2017
+254 −2

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
cncf-cla: yes enhancement nginx
Projects
None yet
Milestone
No milestone
6 participants
@aledbf @k8s-reviewable @coveralls @bigkraig @k8s-ci-robot @justinsb
@aledbf
Member

aledbf commented Feb 7, 2017

fixes #180

@aledbf aledbf added backend/generic nginx enhancement labels Feb 7, 2017

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes labels Feb 7, 2017

@k8s-reviewable

k8s-reviewable commented Feb 7, 2017

This change is Reviewable
@coveralls

coveralls commented Feb 7, 2017

Coverage Status

Coverage decreased (-0.1%) to 44.223% when pulling cbccff8 on aledbf:set-headers into 4eb527d on kubernetes:master.
@coveralls

coveralls commented Feb 7, 2017

Coverage Status

Coverage decreased (-0.2%) to 44.183% when pulling cbccff8 on aledbf:set-headers into 4eb527d on kubernetes:master.
@aledbf
Add support for custom proxy headers using a ConfigMap

All checks have passed

3 successful checks
@thelinuxfoundation
cla/linuxfoundation — aledbf authorized
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
coverage/coveralls — Coverage decreased (-0.2%) to 44.223%
Details
5cc5669
@coveralls

coveralls commented Feb 7, 2017

Coverage Status

Coverage decreased (-0.2%) to 44.223% when pulling 5cc5669 on aledbf:set-headers into 2045786 on kubernetes:master.
@bigkraig
Contributor

bigkraig commented Feb 10, 2017

This is a huge help for what I am working on, thanks!!
@bigkraig
Contributor

bigkraig commented Feb 11, 2017 •
Edited 1 time

@aledbf, any chance we can get the StoreToNodeLister added? I am not sure how else to get the node IPs for my NodePort targets.

I sent you a PR that includes the Node lister aledbf#1
@aledbf
Add example

All checks have passed

3 successful checks
@thelinuxfoundation
cla/linuxfoundation — aledbf authorized
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
coverage/coveralls — Coverage increased (+1.4%) to 45.818%
Details
f7a27eb

@aledbf aledbf changed the title from WIP: Add support for custom proxy headers using a ConfigMap to Add support for custom proxy headers using a ConfigMap Feb 11, 2017

@coveralls

coveralls commented Feb 11, 2017

Coverage Status

Coverage increased (+1.4%) to 45.818% when pulling f7a27eb on aledbf:set-headers into 2045786 on kubernetes:master.

@aledbf aledbf assigned justinsb and unassigned justinsb Feb 11, 2017

@aledbf aledbf merged commit b5819d8 into kubernetes:master Feb 16, 2017
3 checks passed

3 checks passed

cla/linuxfoundation aledbf authorized
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+1.4%) to 45.818%
Details

@aledbf aledbf deleted the aledbf:set-headers branch Feb 16, 2017

@n1koo n1koo referenced this pull request May 18, 2017

Merged

Add support for add_headers #730

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment