Join GitHub today
fixed rewrites for paths not ending in / #2899
What this PR does / why we need it:
Make sure that rewrites work correctly for paths without terminating slash.
Which issue this PR fixes (optional, in
Special notes for your reviewer:
I did update the unit tests and it runs with errors relating to the rewrite stuff, but I couldn't get the e2e tests to run without failing. Then again, those failed with a clean master branch checkout as well so maybe I did something wrong there altogether.
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
@@ Coverage Diff @@ ## master #2899 +/- ## ========================================== + Coverage 47.57% 47.58% +<.01% ========================================== Files 77 77 Lines 5532 5533 +1 ========================================== + Hits 2632 2633 +1 Misses 2560 2560 Partials 340 340
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing