New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix docu to use new app label #3001

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
6 participants
@aolsux

aolsux commented Aug 28, 2018

#2970 changed the labels. Using the new labels, the tutorial does not work any more. This just adapts the docu to the changed labels.

@k8s-ci-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-ci-robot

k8s-ci-robot Aug 28, 2018

Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Contributor

k8s-ci-robot commented Aug 28, 2018

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-ci-robot

k8s-ci-robot Aug 28, 2018

Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: aolsux
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: bowei

If they are not already assigned, you can assign the PR to them by writing /assign @bowei in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Contributor

k8s-ci-robot commented Aug 28, 2018

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: aolsux
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: bowei

If they are not already assigned, you can assign the PR to them by writing /assign @bowei in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@aolsux

This comment has been minimized.

Show comment
Hide comment
@aolsux

aolsux Aug 28, 2018

I think i signed the cla now....

aolsux commented Aug 28, 2018

I think i signed the cla now....

@aledbf

This comment has been minimized.

Show comment
Hide comment
@aledbf

aledbf Aug 28, 2018

Member

/check-cla

Member

aledbf commented Aug 28, 2018

/check-cla

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Aug 28, 2018

Codecov Report

Merging #3001 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3001   +/-   ##
=======================================
  Coverage   47.54%   47.54%           
=======================================
  Files          77       77           
  Lines        5639     5639           
=======================================
  Hits         2681     2681           
  Misses       2605     2605           
  Partials      353      353

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22cb033...bb9b0ba. Read the comment docs.

codecov-io commented Aug 28, 2018

Codecov Report

Merging #3001 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3001   +/-   ##
=======================================
  Coverage   47.54%   47.54%           
=======================================
  Files          77       77           
  Lines        5639     5639           
=======================================
  Hits         2681     2681           
  Misses       2605     2605           
  Partials      353      353

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22cb033...bb9b0ba. Read the comment docs.

@mikalstill

This comment has been minimized.

Show comment
Hide comment
@mikalstill

mikalstill Sep 4, 2018

Hi, this PR is important because the validation steps in your deploy doc are broken (leaving people with the false impression that nginx isn't working) until this is merged. Thanks!

mikalstill commented Sep 4, 2018

Hi, this PR is important because the validation steps in your deploy doc are broken (leaving people with the false impression that nginx isn't working) until this is merged. Thanks!

hswong3i added a commit to alvistack/ingress-nginx that referenced this pull request Sep 4, 2018

@hswong3i

This comment has been minimized.

Show comment
Hide comment
@hswong3i

hswong3i Sep 4, 2018

Contributor

Please check #3035 which also include this fix ;-)

Contributor

hswong3i commented Sep 4, 2018

Please check #3035 which also include this fix ;-)

hswong3i added a commit to alvistack/ingress-nginx that referenced this pull request Sep 4, 2018

Fixup #2970: Add Missing Label `app.kubernetes.io/part-of: ingress-ng…
…inx`

-    Add missing label `app.kubernetes.io/part-of: ingress-nginx` for deploy example
-    Update test cases for new labels
-    Update docs for new labels

Also close #3001

hswong3i added a commit to alvistack/ingress-nginx that referenced this pull request Sep 5, 2018

Fixup #2970: Add Missing Label `app.kubernetes.io/part-of: ingress-ng…
…inx`

-    Add missing label `app.kubernetes.io/part-of: ingress-nginx` for deploy example
-    Update new labels for docs/deploy and docs/examples
-    Update new labels for test/e2e and test/manifests
-    Update new labels for images/nginx

Also close #3001

@k8s-ci-robot k8s-ci-robot closed this in #3035 Sep 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment