New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix logging calls #3260
fix logging calls #3260
Conversation
@@ -118,7 +118,7 @@ func ReadConfig(src map[string]string) config.Configuration { | |||
bindAddressIpv4List = append(bindAddressIpv4List, fmt.Sprintf("%v", ns)) | |||
} | |||
} else { | |||
glog.Warningf("%v is not a valid textual representation of an IP address", i) | |||
glog.Warning("%v is not a valid textual representation of an IP address", i) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is fine
glog.Warning("%v is not a valid textual representation of an IP address", i) | |
glog.Warningf("%v is not a valid textual representation of an IP address", i) |
@aledbf The Travis CI build failed?How do I solve this problem? |
I restarted the failed build. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: antoineco, mikeweiwei The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@mikeweiwei please rebase to pass CI |
Adds per-server/location error-catch functionality to nginx template Adds documentation Reduces template duplication with helper function for CUSTOM_ERRORS data Updates documentation Adds e2e test for customerrors Add healthcheck timeout as CLA Update kubeadm-dind-cluster (kubernetes#3304) Add e2e test for force-ssl-redirect enhance test logic Refactor EWMA to not use shared dictionaries Add e2e test for server snippet Adds the e2e test for server snippet. Similar test to the configuration snippet. Part of the kubernetes#3124 effort. Add e2e test for app-root Add e2e tests for IP Whitelist Adds e2e test for the whitelist-source-range annotation. Part of the kubernetes#3124 effort. fix logging calls (kubernetes#3260) "diretly" typo (kubernetes#3263) * "diretly" typo Bump geoip2 module version 3.0 -> 3.2 Fix download of geoip2 databases Delete some extra words Update nginx and add support for TLSv1.3 Fix links in deploy index docs Update nginx image and QEMU version Fix status update in case of connection errors Update e2e image Add configuration for geoip2 module Based on closed PRs kubernetes#2551, kubernetes#2755 sticky session e2e test fix sticky session implementation Remove e2e boilerplate Fix e2e tests Update build-single-manifest-sh Code linting Avoid reloads when endpoints are not available fix baremetal.md link
What this PR does / why we need it:
If don't use formatted output,fix logging calls
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #Special notes for your reviewer: