Fix some typos #3282
Fix some typos #3282
Conversation
k8s-ci-robot
added
kind/cleanup
k8s-ci-robot
added
the
size/XS
|
/assign @antoineco |
Changelog.md
Outdated
| @@ -66,7 +66,7 @@ _Documentation:_ | |||
| - [X] [#3090](https://github.com/kubernetes/ingress-nginx/pull/3090) Add note about default namespace and merge behavior | |||
| - [X] [#3092](https://github.com/kubernetes/ingress-nginx/pull/3092) Update mkdocs and travis-ci | |||
| - [X] [#3094](https://github.com/kubernetes/ingress-nginx/pull/3094) Fix baremetal images [skip ci] | |||
| - [X] [#3097](https://github.com/kubernetes/ingress-nginx/pull/3097) Added notes to regarding external access when using TCP/UDP proxy in Ingress | |||
There was a problem hiding this comment.
Don't change the changelog. This file is auto-generated from the issues.
test/e2e/dind-cluster-v1.11.sh
Outdated
| @@ -215,7 +215,7 @@ function dind::get-and-validate-cidrs { | |||
| echo "${cidrs[@]}" | |||
| } | |||
|
|
|||
| # dind::make-ip-from-cidr strips off the slash and size, and appends the | |||
| # dind::make-ip-from-cidr strips off the slash and size, and appends the | |||
There was a problem hiding this comment.
Please don't change the script, this file is copied from from https://github.com/kubernetes-sigs/kubeadm-dind-cluster/blob/master/fixed/dind-cluster-v1.11.sh
|
@aledbf Thanks for your reminding! I have resubmited it. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, SataQiu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@SataQiu thanks! |
k8s-ci-robot
added
the
approved
What this PR does / why we need it:
Fix some typos that I found.
/kind cleanup
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer: