Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix forwarded host parsing #3950

Merged

Conversation

@ElvinEfendi
Copy link
Member

commented Mar 31, 2019

What this PR does / why we need it:

Sometimes reverse proxies keep appending to X-Forwarded-Host header that results in multiple comma separated value. This PR makes sure we always set a single host to proxy Host header by splitting the X-Forwarded-Host value by comma and taking only the first host in the list.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #3790

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot requested review from aledbf and bowei Mar 31, 2019

@ElvinEfendi ElvinEfendi force-pushed the ElvinEfendi:fix-forwarded-host-parsing branch from 48bd0dc to 12899df Mar 31, 2019

@k8s-ci-robot k8s-ci-robot added size/M and removed size/L labels Mar 31, 2019

@ElvinEfendi ElvinEfendi changed the title [wip] Fix forwarded host parsing Fix forwarded host parsing Mar 31, 2019

@ElvinEfendi ElvinEfendi force-pushed the ElvinEfendi:fix-forwarded-host-parsing branch from 12899df to 87e9626 Mar 31, 2019

@aledbf

This comment has been minimized.

Copy link
Member

commented Mar 31, 2019

/lgtm

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Mar 31, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, ElvinEfendi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@aledbf aledbf added this to done in 0.24.0 Mar 31, 2019

@k8s-ci-robot k8s-ci-robot merged commit 662a4d0 into kubernetes:master Mar 31, 2019

3 checks passed

cla/linuxfoundation ElvinEfendi authorized
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
tide In merge pool.
Details

@ElvinEfendi ElvinEfendi deleted the ElvinEfendi:fix-forwarded-host-parsing branch Mar 31, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
3 participants
You can’t perform that action at this time.