Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove stop controller endpoint #4100

Merged
merged 1 commit into from May 22, 2019
Merged

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented May 18, 2019

What this PR does / why we need it:

Removes the /stop endpoint. This is something introduced in the first versions of the controller.
Related to #4052

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 18, 2019
@codecov-io
Copy link

codecov-io commented May 18, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@1bd3fd2). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #4100   +/-   ##
=========================================
  Coverage          ?   57.75%           
=========================================
  Files             ?       87           
  Lines             ?     6488           
  Branches          ?        0           
=========================================
  Hits              ?     3747           
  Misses            ?     2311           
  Partials          ?      430
Impacted Files Coverage Δ
cmd/nginx/main.go 6.71% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bd3fd2...32fda20. Read the comment docs.

@aledbf aledbf added this to In Progress in 0.25.0 May 18, 2019
@ElvinEfendi
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 22, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, ElvinEfendi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 0bdca63 into kubernetes:master May 22, 2019
@aledbf aledbf deleted the remove-stop branch May 22, 2019 13:50
@aledbf aledbf moved this from In Progress to done in 0.25.0 May 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
No open projects
0.25.0
  
done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants