Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RBAC issues with networking.k8s.io #4298

Merged
merged 1 commit into from Jul 9, 2019

Conversation

@aledbf
Copy link
Member

commented Jul 9, 2019

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #4296

Special notes for your reviewer:

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jul 9, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@aledbf aledbf merged commit e0e7b57 into kubernetes:master Jul 9, 2019

1 of 11 checks passed

pull-ingress-nginx-boilerplate Job triggered.
Details
pull-ingress-nginx-codegen Job triggered.
Details
pull-ingress-nginx-e2e-1-12 Job triggered.
Details
pull-ingress-nginx-e2e-1-13 Job triggered.
Details
pull-ingress-nginx-e2e-1-14 Job triggered.
Details
pull-ingress-nginx-e2e-1-15 Job triggered.
Details
pull-ingress-nginx-gofmt Job triggered.
Details
pull-ingress-nginx-golint Job triggered.
Details
pull-ingress-nginx-test Job triggered.
Details
pull-ingress-nginx-test-lua Job triggered.
Details
cla/linuxfoundation aledbf authorized
Details

@aledbf aledbf added this to done in 0.26.0 Jul 9, 2019

@aledbf aledbf deleted the aledbf:rbac branch Jul 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.