Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable publish-service for ClusterIP type service. fixes #4461 #4462

Closed
wants to merge 1 commit into from

Conversation

@rtnpro
Copy link

commented Aug 18, 2019

What this PR does / why we need it:

This pull request enables publishing the ClusterIP for nginx-ingress-controller service when the service's type is ClusterIP.

Which issue this PR fixes
fixes #4461

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 18, 2019

Welcome @rtnpro!

It looks like this is your first PR to kubernetes/ingress-nginx 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/ingress-nginx has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 18, 2019

Hi @rtnpro. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 18, 2019

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rtnpro
To complete the pull request process, please assign aledbf
You can assign the PR to them by writing /assign @aledbf in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from aledbf and ElvinEfendi Aug 18, 2019

@rtnpro

This comment has been minimized.

Copy link
Author

commented Aug 18, 2019

I have tested this PR in my Kubernetes cluster, and it's able to publish the ClusterIP of the nginx-ingress-controller ClusterIP type service to the associated ingress objects.

If this change is desirable, then I can go ahead with adding tests for this fix.

@aledbf

This comment has been minimized.

Copy link
Member

commented Aug 18, 2019

@rtnpro I am sorry but ClusterIP addresses are not routable outside the cluster. That's the reason why
this is not supported. What are you trying to do exactly?

@aledbf aledbf added the do-not-merge label Aug 18, 2019

@rtnpro

This comment has been minimized.

Copy link
Author

commented Aug 18, 2019

@rtnpro

This comment has been minimized.

Copy link
Author

commented Aug 19, 2019

@aledbf ping!

@rtnpro

This comment has been minimized.

Copy link
Author

commented Aug 24, 2019

@aledbf Hey, I have written a blog post explaining why we need this feature: https://rtnpro.com/enabling-publish-service-for-clusterip-nginx-ingress-controller-service/

Let me know what you think about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.