Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for multiple alias and remove duplication of SSL certific… #4472

Merged
merged 1 commit into from Aug 26, 2019

Conversation

@aledbf
Copy link
Member

commented Aug 20, 2019

…ates

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #4388

Special notes for your reviewer:

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 20, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@aledbf aledbf added this to In Progress in 0.26.0 Aug 20, 2019
@aledbf aledbf force-pushed the aledbf:refactor-alias branch from 1020fc0 to 3eea28c Aug 20, 2019
@aledbf aledbf force-pushed the aledbf:refactor-alias branch 2 times, most recently from 0de8eb3 to 7c3e6e5 Aug 20, 2019
@aledbf

This comment has been minimized.

Copy link
Member Author

commented Aug 20, 2019

/test pull-ingress-nginx-e2e-1-12

@aledbf aledbf force-pushed the aledbf:refactor-alias branch from 7c3e6e5 to 5af0cac Aug 20, 2019
@aledbf

This comment has been minimized.

Copy link
Member Author

commented Aug 20, 2019

/test pull-ingress-nginx-test

@codecov-io

This comment has been minimized.

Copy link

commented Aug 20, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (master@4847bb0). Click here to learn what that means.
The diff coverage is 55.73%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #4472   +/-   ##
=========================================
  Coverage          ?   59.23%           
=========================================
  Files             ?       89           
  Lines             ?     6773           
  Branches          ?        0           
=========================================
  Hits              ?     4012           
  Misses            ?     2334           
  Partials          ?      427
Impacted Files Coverage Δ
internal/ingress/sslcert.go 0% <ø> (ø)
internal/ingress/controller/template/configmap.go 77.4% <ø> (ø)
internal/ingress/types.go 0% <ø> (ø)
internal/ingress/types_equals.go 17.39% <0%> (ø)
internal/ingress/annotations/annotations.go 81.69% <100%> (ø)
internal/ingress/controller/store/backend_ssl.go 51.76% <100%> (ø)
internal/net/ssl/ssl.go 50.98% <100%> (ø)
internal/ingress/annotations/alias/main.go 100% <100%> (ø)
internal/ingress/controller/controller.go 47.6% <40%> (ø)
internal/ingress/controller/nginx.go 29.44% <58.82%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4847bb0...b7ee239. Read the comment docs.

@aledbf aledbf force-pushed the aledbf:refactor-alias branch from 5af0cac to e61bed1 Aug 22, 2019
@aledbf aledbf force-pushed the aledbf:refactor-alias branch from e61bed1 to c90ffd4 Aug 26, 2019
@aledbf aledbf force-pushed the aledbf:refactor-alias branch from c90ffd4 to 13924b2 Aug 26, 2019
@aledbf aledbf force-pushed the aledbf:refactor-alias branch from 13924b2 to 94346a5 Aug 26, 2019
internal/net/ssl/ssl.go Outdated Show resolved Hide resolved
@aledbf aledbf force-pushed the aledbf:refactor-alias branch from 94346a5 to d9f418c Aug 26, 2019
…ates
@aledbf aledbf force-pushed the aledbf:refactor-alias branch from d9f418c to b7ee239 Aug 26, 2019
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 26, 2019

@aledbf: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-ingress-nginx-test-lua b7ee239 link /test pull-ingress-nginx-test-lua

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@aledbf aledbf merged commit 8def5ef into kubernetes:master Aug 26, 2019
11 of 13 checks passed
11 of 13 checks passed
pull-ingress-nginx-test-lua Job failed.
Details
tide Not mergeable. Needs lgtm label.
Details
cla/linuxfoundation aledbf authorized
Details
pull-ingress-nginx-boilerplate Job succeeded.
Details
pull-ingress-nginx-codegen Job succeeded.
Details
pull-ingress-nginx-e2e-1-12 Job succeeded.
Details
pull-ingress-nginx-e2e-1-13 Job succeeded.
Details
pull-ingress-nginx-e2e-1-14 Job succeeded.
Details
pull-ingress-nginx-e2e-1-15 Job succeeded.
Details
pull-ingress-nginx-gofmt Job succeeded.
Details
pull-ingress-nginx-golint Job succeeded.
Details
pull-ingress-nginx-lualint Job succeeded.
Details
pull-ingress-nginx-test Job succeeded.
Details
@aledbf aledbf moved this from In Progress to done in 0.26.0 Aug 26, 2019
@aledbf aledbf deleted the aledbf:refactor-alias branch Aug 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
4 participants
You can’t perform that action at this time.