Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use admissionregistration.k8s.io/v1beta1 to be k8s < 1.16 compatible #5770

Merged
merged 1 commit into from Jun 24, 2020

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Jun 24, 2020

What this PR does / why we need it:

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Which issue/s this PR fixes

fixes #5769

How Has This Been Tested?

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 24, 2020
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 24, 2020
@ChiefAlexander
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 24, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, ChiefAlexander

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ChiefAlexander
Copy link
Contributor

As discussed in our slack conversation I think that we should define what we at a minimum support for this chart for Kubernetes versions. And then for these versions of APIs that change provide a default for the versions with the ability to overwrite them via our vars.

@aledbf
Copy link
Member Author

aledbf commented Jun 24, 2020

/retest

@k8s-ci-robot k8s-ci-robot merged commit d7f7e16 into kubernetes:master Jun 24, 2020
@aledbf aledbf added this to done in 0.34.0 Jun 24, 2020
@aledbf aledbf deleted the webhook branch June 24, 2020 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
No open projects
0.34.0
  
done
Development

Successfully merging this pull request may close these issues.

Issue with installing 2.7.1 - No matches for ValidatingWebhookConfiguration
3 participants