Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start using e2e test images from gcr.io #5807

Merged
merged 3 commits into from Jun 27, 2020
Merged

Start using e2e test images from gcr.io #5807

merged 3 commits into from Jun 27, 2020

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Jun 27, 2020 •
edited

What this PR does / why we need it:

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Which issue/s this PR fixes

How Has This Been Tested?

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 27, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 27, 2020
@aledbf
Copy link
Member Author

aledbf commented Jun 27, 2020

/retest

1 similar comment
@aledbf
Copy link
Member Author

aledbf commented Jun 27, 2020

/retest

@aledbf aledbf added this to In Progress in 0.34.0 Jun 27, 2020
@aledbf
Copy link
Member Author

aledbf commented Jun 27, 2020

/retest

3 similar comments
@aledbf
Copy link
Member Author

aledbf commented Jun 27, 2020

/retest

@aledbf
Copy link
Member Author

aledbf commented Jun 27, 2020

/retest

@aledbf
Copy link
Member Author

aledbf commented Jun 27, 2020

/retest

@aledbf
Copy link
Member Author

aledbf commented Jun 27, 2020

/test pull-ingress-nginx-e2e-1-17
/test pull-ingress-nginx-e2e-1-18

@aledbf aledbf merged commit 40738fc into kubernetes:master Jun 27, 2020
@aledbf aledbf moved this from In Progress to done in 0.34.0 Jun 27, 2020
@aledbf aledbf deleted the stage branch June 29, 2020 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmluciano cmluciano Awaiting requested review from cmluciano

@ElvinEfendi ElvinEfendi Awaiting requested review from ElvinEfendi

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
No open projects
0.34.0
  
done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aledbf @k8s-ci-robot