Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix wrong links and punctuations #145

Merged
merged 2 commits into from Jan 21, 2017

Conversation

chentao1596
Copy link

@chentao1596 chentao1596 commented Jan 20, 2017

First commit: According to my understanding, "upstreams" should be replaced by "backends".

Second commit:

  1. line 225 and line 271 used the wrong punctuations
  2. i changed other punctuations refer to Document nginx controller configuration tweaks #132

thank you!

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 20, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@coveralls
Copy link

Coverage Status

Coverage remained the same at 43.285% when pulling 7bcdef0 on chentao1596:configuration-correct into fbcedc0 on kubernetes:master.

@aledbf aledbf self-assigned this Jan 21, 2017
@aledbf
Copy link
Member

aledbf commented Jan 21, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 21, 2017
@aledbf
Copy link
Member

aledbf commented Jan 21, 2017

@chentao1596 thanks!

@aledbf aledbf merged commit 22d74df into kubernetes:master Jan 21, 2017
@chentao1596 chentao1596 deleted the configuration-correct branch February 10, 2017 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants