Support hostnames in Ingress status #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
This change is |
|
LGTM |
|
Feel free to merge once travis passes |
bprashanth
added
the
lgtm
hnrytrn
pushed a commit
to hnrytrn/ingress-nginx
that referenced
this pull request
Jul 5, 2018
…nditionally Revert "Deterministic temp dir"
haoqing0110
referenced
this pull request
in stolostron/management-ingress
Mar 5, 2021
The nginx-kube.conf file was hardcoding the name of the ssl secret path to router_certs. In 3.2 a new secret name is used. Modified the code to use the --default-ssl-certificate parameter for the secret name.
haoqing0110
referenced
this pull request
in stolostron/management-ingress
Mar 5, 2021
Add OWNERS file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In AWS a service with
type:Loadbalanceruses a FQDN instead of IPsfixes #50