Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promote CoreDNS v1.7.1 and v1.8.0 #1405

Merged
merged 1 commit into from Nov 10, 2020
Merged

Promote CoreDNS v1.7.1 and v1.8.0 #1405

merged 1 commit into from Nov 10, 2020

Conversation

stp-ip
Copy link
Member

@stp-ip stp-ip commented Nov 10, 2020

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 10, 2020
@k8s-ci-robot k8s-ci-robot added area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects wg/k8s-infra approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 10, 2020
rajansandeep
rajansandeep approved these changes Nov 10, 2020
View reviewed changes
Copy link
Contributor

@rajansandeep rajansandeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
thank you @stp-ip

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 10, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rajansandeep, stp-ip

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit a2b5cf4 into kubernetes:master Nov 10, 2020
@stp-ip stp-ip deleted the coredns_promotion branch November 10, 2020 16:56
@rajansandeep rajansandeep mentioned this pull request Nov 10, 2020
Merged
@rajansandeep
Copy link
Contributor

Is there a time frame as to when the images are promoted?
Seems like the images aren't available in k8s.gcr.io yet

@stp-ip
Copy link
Member Author

stp-ip commented Nov 11, 2020

Should be quite close after merge. Will check what's up.

@stp-ip
Copy link
Member Author

stp-ip commented Nov 11, 2020 •
edited

Jobs ran without error and checked the repo as well: https://console.cloud.google.com/gcr/images/k8s-artifacts-prod/EU/coredns/coredns?gcrImageListsize=30

The last version v1.7.0 was not yet using a subpath due to it using the legacy promotion.

We now have a subpath so it should be available under k8s.gcr.io/coredns/coredns:v1.8.0 and k8s.gcr.io/coredns/coredns:v1.7.1.

On mobile so can't check myself.

@chrisohaver
Copy link

@stp-ip thanks! I checked and it works.

@rajansandeep rajansandeep mentioned this pull request Feb 22, 2021
Closed
@pacoxu pacoxu mentioned this pull request Apr 21, 2021
Closed
@LuckySB LuckySB mentioned this pull request Jun 11, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rajansandeep rajansandeep rajansandeep approved these changes

@chrisohaver chrisohaver Awaiting requested review from chrisohaver

Assignees

@rajansandeep rajansandeep

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@stp-ip @k8s-ci-robot @rajansandeep @chrisohaver