terraform/k8s-infra-kubernetes-io: manage k8s-infra-sandbox-capg budget #2940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
|
|
A module to manage organization-level resources, including: - a project to use for APIs that only make sense to be enabled in the context of org management, like billing or orgpolicy - a lien on kubernetes-public to make sure it's not accidentally deleted, as a demonstration of how we could use liens - a budget for k8s-infra-sandbox-capg Setting up the project required a little bit of a manual work, because in order for terraform to use a project for billing purposes, the project needs to already exist and have certain services enabled. This involved: - commenting out "user_project_override" to use a gcloud project with cloudresourcemanager and serviceusage APIs enabled - commenting out terraform resources that weren't directly related to the creation/services of the k8s-infra-kubernetes-io project - running terraform apply - uncommenting everything - running terraform apply again This was necessary because the Google Cloud billing budgets API does not work with user credentials (which is how we've been authenticating and using terraform thus far)
spiffxp
force-pushed
the
k8s-infra-org-tf
branch
from
1dc4497
to
0beacba
Compare
spiffxp
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
$3M/y / 12 mo/y = $250K/mo, alert at 90% (225K) and 100%
|
Added a monthly budget for k8s-infra as a whole, we'll get e-mail alerts if we hit 90% (225K) for the month, which we have been. |
|
/approve thanks @spiffxp please remove hold when ready |
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
endocrimes
approved these changes
Oct 14, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, endocrimes, spiffxp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
|
/lgtm |
ameukam
reviewed
Oct 14, 2021
Comment on lines
+59
to
+62
| data "google_monitoring_notification_channel" "sig_k8s_infra_leads" { | ||
| project = data.google_project.kubernetes_public.project_id | ||
| display_name = "sig-k8s-infra-leads@kubernetes.io" | ||
| } |
There was a problem hiding this comment.
Why not directly manage this with Terraform ? (use a resource)
There was a problem hiding this comment.
And I think Steering should be get notified when the threshold reach a critical percentage of the budget defined
There was a problem hiding this comment.
I'll tackle these in a followup
This was referenced Oct 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related:
A module to manage organization-level resources, including:
context of org management, like billing or orgpolicy
deleted, as a demonstration of how we could use liens
Setting up the project required a little bit of a manual work, because
in order for terraform to use a project for billing purposes, the
project needs to already exist and have certain services enabled. This
involved:
cloudresourcemanager and serviceusage APIs enabled
the creation/services of the k8s-infra-kubernetes-io project
This was necessary because the Google Cloud billing budgets API does not
work with user credentials (which is how we've been authenticating and
using terraform thus far), ref: https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/billing_budget