Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify variables in terraform config #352

Merged
merged 1 commit into from Sep 4, 2019

Conversation

@cblecker
Copy link
Member

commented Sep 4, 2019

After a session this afternoon with @thockin, some changes that simplify the terraform config.

The goal here is readability vs DRY-ness. We can do that later if need be.

@cblecker cblecker force-pushed the cblecker:tf-simplify branch from c0e8b94 to a8f4f71 Sep 4, 2019

@k8s-ci-robot k8s-ci-robot added the lgtm label Sep 4, 2019

@thockin
Copy link
Member

left a comment

AFAICT, this makes sense. Still learning it and still running through it piece by piece, myself.

/lgtm
/approve

@thockin thockin added the approved label Sep 4, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Sep 4, 2019

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit c4143be into kubernetes:master Sep 4, 2019

2 of 3 checks passed

tide Not mergeable. Needs approved, lgtm labels.
Details
cla/linuxfoundation cblecker authorized
Details
pull-k8sio-cip Skipped.

@cblecker cblecker deleted the cblecker:tf-simplify branch Sep 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.