Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds k8s-infra-staging-e2e-test-images@kubernetes.io group #400

Merged
merged 1 commit into from Dec 6, 2019

Conversation

@claudiubelu
Copy link
Contributor

claudiubelu commented Oct 16, 2019

The group is meant to own pushing rights to the gcr.io/kubernetes-staging-e2e-test-images registry, which will contain the images to be promoted to the gcr.io/kubernetes-e2e-test-images registry.

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Oct 16, 2019

Welcome @bclau!

It looks like this is your first PR to kubernetes/k8s.io 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/k8s.io has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@claudiubelu claudiubelu force-pushed the claudiubelu:adds-e2e-test-images branch from 933e27b to 18e70a7 Oct 16, 2019
@k8s-ci-robot k8s-ci-robot requested review from cblecker and nikhita Oct 16, 2019
@claudiubelu claudiubelu force-pushed the claudiubelu:adds-e2e-test-images branch from 18e70a7 to d03d6c6 Oct 16, 2019
@@ -52,6 +52,7 @@ STAGING_PROJECTS=(
coredns
csi
descheduler
e2e-test-images

This comment has been minimized.

Copy link
@thockin

thockin Oct 16, 2019

Member

We get one shot at naming. Does "images" add enough value here, or is "e2e-test" or "test-e2e" or "testing/e2e" or even just "e2e" sufficient?

This comment has been minimized.

Copy link
@claudiubelu

claudiubelu Oct 16, 2019

Author Contributor

Is there a reason why the name needs to be shortened?

If so, I'd rather go with e2e-test, unless you're suggesting otherwise.

Copy link
Member

thockin left a comment

Other than naming, this seems good.

I assume you want the second part, which is the Prow config to enable auto-build and auto-push thru GCB.

@Katharine do you have a template PR or docs on how to enable this? We should embed that into https://github.com/kubernetes/k8s.io/blob/master/k8s.gcr.io/README.md

Copy link
Contributor Author

claudiubelu left a comment

Seems like we're going to need another 2 PRs:

  • PR that adds cloudbuild.yaml in kubernetes/kubernetes
  • PR in kubernetes/test-infra containing a prow job config.

Will try to send them in the morning,

@@ -52,6 +52,7 @@ STAGING_PROJECTS=(
coredns
csi
descheduler
e2e-test-images

This comment has been minimized.

Copy link
@claudiubelu

claudiubelu Oct 16, 2019

Author Contributor

Is there a reason why the name needs to be shortened?

If so, I'd rather go with e2e-test, unless you're suggesting otherwise.

@claudiubelu

This comment has been minimized.

Copy link
Contributor Author

claudiubelu commented Oct 17, 2019

I've sent the other 2 required PRs:

kubernetes/kubernetes#84058
kubernetes/test-infra#14833

Hopefully I got it right.

The group is meant to own pushing rights to the gcr.io/k8s-staging-e2e-test-images
registry, which will contain the images to be promoted to the gcr.io/kubernetes-e2e-test-images
registry.
Copy link
Member

cblecker left a comment

/hold

groups/groups.yaml changes need to be rebased and brought in

@claudiubelu claudiubelu force-pushed the claudiubelu:adds-e2e-test-images branch from d03d6c6 to 03fdf5d Oct 28, 2019
@k8s-ci-robot k8s-ci-robot added size/M and removed size/S labels Oct 28, 2019
@claudiubelu

This comment has been minimized.

Copy link
Contributor Author

claudiubelu commented Oct 29, 2019

/hold

groups/groups.yaml changes need to be rebased and brought in

done

@smourapina

This comment has been minimized.

Copy link
Member

smourapina commented Oct 30, 2019

/milestone v1.17

Adding to milestone 1.17, as suggested in kubernetes/kubernetes#81170 (comment)

@claudiubelu claudiubelu force-pushed the claudiubelu:adds-e2e-test-images branch from 03fdf5d to c4bdc36 Nov 5, 2019
@claudiubelu

This comment has been minimized.

Copy link
Contributor Author

claudiubelu commented Nov 11, 2019

/hold cancel

@dims

This comment has been minimized.

Copy link
Member

dims commented Dec 6, 2019

/approve
/lgtm

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Dec 6, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 1f9a39b into kubernetes:master Dec 6, 2019
2 of 3 checks passed
2 of 3 checks passed
tide Not mergeable. Retesting: pull-k8sio-groups-test
Details
cla/linuxfoundation bclau authorized
Details
pull-k8sio-groups-test Job succeeded.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.