Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix groups settings for steering list #462

Merged
merged 1 commit into from Nov 11, 2019

Conversation

@cblecker
Copy link
Member

cblecker commented Nov 11, 2019

I had fixed settings so anyone could post to the steering public list, but it still wasn't publicly viewable

/assign @dims

@dims

This comment has been minimized.

Copy link
Member

dims commented Nov 11, 2019

/approve
/lgtm
/hold

( for actually running the script, please unhold when you are able to @cblecker )

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Nov 11, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cblecker

This comment has been minimized.

Copy link
Member Author

cblecker commented Nov 11, 2019

/hold cancel

Thanks @dims!

@k8s-ci-robot k8s-ci-robot merged commit 1416390 into kubernetes:master Nov 11, 2019
2 of 3 checks passed
2 of 3 checks passed
tide Not mergeable. Should not have do-not-merge/hold label.
Details
cla/linuxfoundation cblecker authorized
Details
pull-k8sio-groups-test Job succeeded.
Details
@cblecker cblecker deleted the cblecker:fix-steering-settings branch Nov 11, 2019
@cblecker

This comment has been minimized.

Copy link
Member Author

cblecker commented Nov 11, 2019

Applied

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.