Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Update Dockerfile and requirements.txt for python 3.7 #469
Hi @puerco. Thanks for your PR.
I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with
Once the patch is verified, the new status will be reflected by the
I understand the commands that are listed here.
I've been testing the script under python3 on a different zone on GCP and it seems to run fine, although I'm not sure if it does what it is supposed to:
What it currently does is read the dns zones from Cloud DNS and compare them to what the resolvers are answering. In other words it is just testing if gcp is doing its job.
From what I gather from @cblecker 's comment, it should compare the zones from the YAML configuration against the actual dns responses from the resolvers. Am I wrong? I have a patch ready if this is the intended behavior.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: dims
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing
On Fri, Dec 6, 2019 at 4:29 PM Puerco ***@***.***> wrote: Thanks @dims <https://github.com/dims> i will send the patch in the morning. BTW, this resolves issue #415 <#415> — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#469?email_source=notifications&email_token=AAHADKZXPCGGHS4WZGOSO5DQXLU5DA5CNFSM4JNR2MT2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGFYNVA#issuecomment-562792148>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAHADKYMDOCAVV6P27EIRDDQXLU5DANCNFSM4JNR2MTQ> .