Skip to content

Image promotion for scl-image-builder v0.1.15 - #5262

Merged
k8s-ci-robot merged 1 commit into
kubernetes:mainfrom
jsturtevant:scl-image-builder-v0.1.15-image-promotion
May 11, 2023
Merged

Image promotion for scl-image-builder v0.1.15#5262
k8s-ci-robot merged 1 commit into
kubernetes:mainfrom
jsturtevant:scl-image-builder-v0.1.15-image-promotion

Conversation

@jsturtevant

@jsturtevant jsturtevant commented May 11, 2023

Copy link
Copy Markdown
Contributor

Image promotion for scl-image-builder v0.1.15
This is an automated PR generated from kpromo

kpromo pr --fork jsturtevant --project scl-image-builder --reviewers "@jsturtevant @kkeshavamurthy @mboersma @AverageMarcus" --tag v0.1.15

/hold
cc: @jsturtevant @kkeshavamurthy @mboersma @AverageMarcus

@jsturtevant
Image promotion for scl-image-builder v0.1.15
ae8a2b7 
Signed-off-by: James Sturtevant <jstur@microsoft.com>
@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects labels May 11, 2023
@k8s-ci-robot
k8s-ci-robot requested review from justinsb and moshloop May 11, 2023 16:27
@k8s-ci-robot k8s-ci-robot added area/registry.k8s.io Code in registry.k8s.io/ sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 11, 2023
AverageMarcus
AverageMarcus reviewed May 11, 2023
View reviewed changes

@AverageMarcus AverageMarcus left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 11, 2023
mboersma
mboersma approved these changes May 11, 2023
View reviewed changes

@mboersma mboersma left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 11, 2023
@mboersma

mboersma commented May 11, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

@CecileRobertMichon would you mind approving this?

(We need to sync up our OWNERS so we can approve future releases, see #5263) Edit: never mind, synced up. Thank you!

@mboersma

mboersma commented May 11, 2023

Copy link
Copy Markdown
Contributor

/approve

@k8s-ci-robot

k8s-ci-robot commented May 11, 2023

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsturtevant, mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 11, 2023
@k8s-ci-robot
k8s-ci-robot merged commit 86d8eca into kubernetes:main May 11, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justinsb justinsb Awaiting requested review from justinsb
@moshloop moshloop Awaiting requested review from moshloop
2 more reviewers
@AverageMarcus AverageMarcus AverageMarcus left review comments
@mboersma mboersma mboersma approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@mboersma mboersma

@AverageMarcus AverageMarcus

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/registry.k8s.io Code in registry.k8s.io/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

v1.28

Development

Successfully merging this pull request may close these issues.

4 participants

@jsturtevant @mboersma @k8s-ci-robot @AverageMarcus