Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow up changes to PR 526 #531

Merged
merged 1 commit into from Jan 10, 2020
Merged

Conversation

@cblecker
Copy link
Member

cblecker commented Jan 8, 2020

This contains follow up changes to #526

#526 (review)

/assign @thockin

infra/gcp/ensure-main-project.sh Outdated Show resolved Hide resolved
infra/gcp/ensure-main-project.sh Outdated Show resolved Hide resolved
@cblecker cblecker force-pushed the cblecker:zone-followup branch from 6c102db to 1afed8b Jan 8, 2020
Copy link
Member

thockin left a comment

Thanks!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label Jan 10, 2020
@cblecker

This comment has been minimized.

Copy link
Member Author

cblecker commented Jan 10, 2020

/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 10, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 7716580 into kubernetes:master Jan 10, 2020
1 of 2 checks passed
1 of 2 checks passed
tide Not mergeable.
Details
cla/linuxfoundation cblecker authorized
Details
@cblecker cblecker deleted the cblecker:zone-followup branch Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.