-vmodule should allow level -1

[michael-db]

/kind bug

It is possible to pass the option -v -1 to disable level 0 logging, in which case only Errors are logged. However, it is not possible to pass a negative number for logging in a particular module, i.e., with the -vmodule option.

What steps did you take and what happened:

: logtest 114; go build && ./logtest -vmodule klogr=-1
invalid value "klogr=-1" for flag -vmodule: negative value for vmodule level

What did you expect to happen:

No error message, all log messages other than Errors for the specified module silenced.

Anything else you would like to add:

[neolit123]

disable level 0 logging

which is essentially disable logging completely?
isn't there a flag to do that already?

[neolit123]

/remove-kind feature
/kind feature
/priority awaiting-more-evidence

[k8s-ci-robot]

@neolit123: Those labels are not set on the issue: kind/feature

In response to this:

/remove-kind feature
/kind feature
/priority awaiting-more-evidence

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[michael-db]

Is there? Level -1 applies only to Info, not Error, so it is not equivalent to disabling logging completely.

  -vmodule value
    	comma-separated list of pattern=N settings for file-filtered logging

If I have missed something then could you please indicate how to use -vmodule to disable all Info logging, but not Error logging, for a particular module.

[michael-db]

: logtest 4;  go build && ./logtest -v -1
E1112 17:39:41.015022    1523 main.go:48]  "msg"="Error." "error"="oops"  

What is required is the equivalent with -vmodule to also work.

[neolit123]

Level -1 applies only to Info, not Error, so it is not equivalent to disabling logging completely.

yes, i guess that's true.

If I have missed something then could you please indicate how to use -vmodule to disable all Info logging, but not Error logging, for a particular module.

ok, i think there is no way of doing that, currently.
the kind/feature label seems valid.

you can also try asking in #klog on the k8s slack if somebody has ideas.

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[fejta-bot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

[k8s-ci-robot]

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.