Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new behavior of kompose up #40

Closed
ngtuna opened this issue Jul 15, 2016 · 11 comments
Closed

new behavior of kompose up #40

ngtuna opened this issue Jul 15, 2016 · 11 comments
Assignees
Labels
kind/design Categorizes issue or PR as related to design. priority/P0

Comments

@ngtuna
Copy link
Contributor

ngtuna commented Jul 15, 2016

Like docker-compose up, kompose up transparently generates default objects and deploy to kubernetes.

@ngtuna
Copy link
Contributor Author

ngtuna commented Jul 15, 2016

Also, print suggestion to use kubectl to deploy other controllers and include non-supported fields warning

@ngtuna ngtuna added the kind/design Categorizes issue or PR as related to design. label Jul 15, 2016
@ngtuna ngtuna self-assigned this Jul 22, 2016
@ngtuna
Copy link
Contributor Author

ngtuna commented Aug 6, 2016

As kompose supports more than one provider, we should have --provider flag like this:

kompose up --provider openshift

Default: Kubernetes (without --provider).

@ngtuna ngtuna closed this as completed in #86 Aug 9, 2016
@ngtuna
Copy link
Contributor Author

ngtuna commented Aug 9, 2016

Reopen it for further enhancement:

  • add --provider flag
  • handling invalid converted k8s object

@ngtuna ngtuna reopened this Aug 9, 2016
@ngtuna
Copy link
Contributor Author

ngtuna commented Aug 16, 2016

@surajssd how can kompose read OpenShift endpoint config ?

@surajssd
Copy link
Member

@ngtuna OpenShift endpoint config as in similar to ~/.kube/config ?

@ngtuna
Copy link
Contributor Author

ngtuna commented Aug 16, 2016

Really? OK so I'm thinking how we can add kompose up --provider openshift. What is the process ? We need to have a ~/.kube/config pre-configured to openshift endpoint. Then let kompose does the same with kubernetes. Does it make sense ?

@kadel
Copy link
Member

kadel commented Aug 17, 2016

I even think that we can use same deploy function (from kubernetes) for deploying to OpenShift.
We just need to make sure that proper api all installed such as (_ "github.com/openshift/origin/pkg/deploy/api/install")
We might change that to _ "github.com/openshift/origin/pkg//api/install" to make sure that all openshift objects are included in schema

@ngtuna
Copy link
Contributor Author

ngtuna commented Aug 20, 2016

Ah.... I remember we discussed about preference file at #39. So, if the preference file is used, we don't need --provider anymore, right ?

@kadel kadel self-assigned this Sep 26, 2016
@kadel
Copy link
Member

kadel commented Sep 26, 2016

I've started working on adding kompose up for openshift.
I will brake it to multiple PRs and in every PR I'm going to reference this issue.

@dustymabe
Copy link
Contributor

I think this can be closed now?

@ngtuna
Copy link
Contributor Author

ngtuna commented Oct 22, 2016

Yes

@ngtuna ngtuna closed this as completed Oct 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/design Categorizes issue or PR as related to design. priority/P0
Projects
None yet
Development

No branches or pull requests

4 participants