Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

volumes long-syntax doesn't work #865

Closed
abitrolly opened this issue Nov 8, 2017 · 7 comments · Fixed by #954
Closed

volumes long-syntax doesn't work #865

abitrolly opened this issue Nov 8, 2017 · 7 comments · Fixed by #954

Comments

@abitrolly
Copy link
Contributor

Conversion matrix specifies that volumes: long-syntax works, but it doesn't, because it requires at least version: '3.2`` in the header to be loaded. For example, this fails to validate with docker-compose`:

version: '3'
services:
  cs-btcd:
    image: cybernode/bitcoin-btcd:temp
    volumes:
      - type: volume
        source: /cyberdata
✗ docker-compose config 
ERROR: The Compose file './docker-compose.yml' is invalid because:
services.cs-btcd.volumes contains an invalid type, it should be a string

The same error is reported by kompose:

✗ kompose convert
FATA services.cs-btcd.volumes.0 must be a string  

Changing version to 3.2 makes docker-compose config pass, but kompose still fails there:

✗ kompose convert       
FATA Version 3.2 of Docker Compose is not supported. Please use version 1, 2 or 3 
@abitrolly
Copy link
Contributor Author

Related to #725

@surajnarwade
Copy link
Contributor

surajnarwade commented Nov 8, 2017

@abitrolly , as of now we don't support docker-compose 3.2 yet
@cdrage we should update conversion-matrix accordingly

@abitrolly
Copy link
Contributor Author

Looks like there is some partial support in https://github.com/kubernetes/kompose/blob/master/pkg/loader/compose/v3.go#L120

@xianlubird
Copy link
Contributor

xianlubird commented Nov 10, 2017

Maybe we can support version 3.1-3.2-3.3-3.4. Docker compose in version 3.x develop fast and many attribute is added into it. We can work together to develop support these new attribute.We can support 3.1 first and step by step to next version.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 8, 2018
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten
/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Mar 10, 2018
@surajnarwade
Copy link
Contributor

/remove-lifecycle rotten

@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Mar 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants