New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix environment with env_file bug #1020

Merged
merged 1 commit into from Jul 10, 2018

Conversation

Projects
None yet
3 participants
@hangyan
Member

hangyan commented May 26, 2018

Fix #1013

@hangyan

This comment has been minimized.

Show comment
Hide comment
@hangyan

hangyan Jul 5, 2018

Member

@cdrage Do you have time to review #1020 #1007 for me? Not in a rush, but i can only continue to work after these PRs merged

Member

hangyan commented Jul 5, 2018

@cdrage Do you have time to review #1020 #1007 for me? Not in a rush, but i can only continue to work after these PRs merged

@cdrage

This comment has been minimized.

Show comment
Hide comment
@cdrage

cdrage Jul 5, 2018

Member

@hangyan Sorry, been busy with other projects. I'll review them now! 👍

Member

cdrage commented Jul 5, 2018

@hangyan Sorry, been busy with other projects. I'll review them now! 👍

@cdrage

cdrage approved these changes Jul 5, 2018

Fix the small added comment, other than that, this LGTM (good job on tests too). After you fix that commented line, LGTM.

Show outdated Hide outdated pkg/loader/compose/v3.go
@cdrage

This comment has been minimized.

Show comment
Hide comment
@cdrage

cdrage Jul 5, 2018

Member

Feel free to merge after the fix

Member

cdrage commented Jul 5, 2018

Feel free to merge after the fix

@hangyan hangyan merged commit c0360e0 into kubernetes:master Jul 10, 2018

2 checks passed

cla/linuxfoundation hangyan authorized
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment