New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support node.labels at placement #1041

Merged
merged 2 commits into from Jul 5, 2018

Conversation

Projects
None yet
3 participants
@jvitor83
Contributor

jvitor83 commented Jun 21, 2018

This PR just give the ability to put any custom label (not mapped) at placement.constraints

    deploy:
      placement:
        constraints:
        - node.labels.something == anything

Just for link the original PR for placement: #813

@hangyan

This comment has been minimized.

Show comment
Hide comment
@hangyan

hangyan Jul 4, 2018

Member

@jvitor83 Hi, Sorry about the very later response. Would mind to add some tests or modify the existing ones? there are many examples there

Member

hangyan commented Jul 4, 2018

@jvitor83 Hi, Sorry about the very later response. Would mind to add some tests or modify the existing ones? there are many examples there

@k8s-ci-robot k8s-ci-robot added size/M and removed size/XS labels Jul 4, 2018

@jvitor83

This comment has been minimized.

Show comment
Hide comment
@jvitor83

jvitor83 Jul 4, 2018

Contributor

@hangyan Hi. I did a test about my modification.

Contributor

jvitor83 commented Jul 4, 2018

@hangyan Hi. I did a test about my modification.

@hangyan

hangyan approved these changes Jul 5, 2018

@hangyan hangyan merged commit 379b654 into kubernetes:master Jul 5, 2018

2 checks passed

cla/linuxfoundation jvitor83 authorized
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@hangyan

This comment has been minimized.

Show comment
Hide comment
@hangyan

hangyan Jul 5, 2018

Member

@jvitor83 Thanks!

Member

hangyan commented Jul 5, 2018

@jvitor83 Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment