Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed go vet #827

Merged
merged 1 commit into from Sep 26, 2017
Merged

Fixed go vet #827

merged 1 commit into from Sep 26, 2017

Conversation

surajnarwade
Copy link
Contributor

Fixes #825 (since go vet was failing locally while doing make test)

@surajnarwade
Fixed go vet
f51a7d0 
Fixes kubernetes#825 (since `go vet` was failing locally while doing `make test`)
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 26, 2017
@cdrage
Copy link
Member

cdrage commented Sep 26, 2017

@surajnarwade Please update commit message to a more descriptive title (don't just like the issue, say what the issue is).

@cdrage
Copy link
Member

cdrage commented Sep 26, 2017

LGTM

@cdrage cdrage merged commit ca496dd into kubernetes:master Sep 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@surajnarwade @cdrage @k8s-ci-robot