New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix custom pvc size in v2 compose not working error #929

Merged
merged 1 commit into from Feb 8, 2018

Conversation

Projects
None yet
4 participants
@hangyan
Member

hangyan commented Feb 7, 2018

fix #927

@cdrage

This comment has been minimized.

Show comment
Hide comment
@cdrage

cdrage Feb 7, 2018

Member

Is it possible for you to add a unit test?

Member

cdrage commented Feb 7, 2018

Is it possible for you to add a unit test?

@cdrage

This comment has been minimized.

Show comment
Hide comment
@cdrage

cdrage Feb 7, 2018

Member

Otherwise, LGTM

Member

cdrage commented Feb 7, 2018

Otherwise, LGTM

@hangyan

This comment has been minimized.

Show comment
Hide comment
@hangyan

hangyan Feb 7, 2018

Member
Member

hangyan commented Feb 7, 2018

@k8s-ci-robot k8s-ci-robot added size/L and removed size/XS labels Feb 8, 2018

@surajnarwade

This comment has been minimized.

Show comment
Hide comment
@surajnarwade

surajnarwade Feb 8, 2018

Collaborator

LGTM

Collaborator

surajnarwade commented Feb 8, 2018

LGTM

@cdrage

This comment has been minimized.

Show comment
Hide comment
@cdrage

cdrage Feb 8, 2018

Member

Tests look good, thanks for the contribution! LGTM.

Member

cdrage commented Feb 8, 2018

Tests look good, thanks for the contribution! LGTM.

@cdrage cdrage merged commit f857afa into kubernetes:master Feb 8, 2018

4 checks passed

cla/linuxfoundation hangyan authorized
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.04%) to 41.765%
Details
semaphoreci The build passed on Semaphore.
Details

@hangyan hangyan deleted the hangyan:fix-v2compose-pvc-size-error branch Mar 31, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment