Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to use a local filesystem state store #6463

Open
ari-becker opened this issue Feb 13, 2019 · 12 comments · May be fixed by #6465

Comments

@ari-becker
Copy link

@ari-becker ari-becker commented Feb 13, 2019

1. What kops version are you running? The command kops version, will display
this information.

1.11.0

2. What Kubernetes version are you running? kubectl version will print the
version if a cluster is running or provide the Kubernetes version specified as
a kops flag.

N/A

3. What cloud provider are you using?

AWS

4. What commands did you run? What is the simplest way to reproduce this issue?

kops create cluster --state 'file:///tmp/kops-state' --zones us-east-1a foo.cluster.k8s.local

5. What happened after the commands executed?

State Store: Invalid value: "file:///tmp/kops-state": Unable to read state store.
Please use a valid state store when setting --state or KOPS_STATE_STORE env var.
For example, a valid value follows the format s3://<bucket>.
Trailing slash will be trimmed.

Issue is caused by vfs.IsClusterReadable returning false for all filesystem state storage as called by factory.Clientset

6. What did you expect to happen?

Not to get an error about being unable to read the state store.

7. Please provide your cluster manifest. Execute
kops get --name my.example.com -o yaml to display your cluster manifest.
You may want to remove your cluster name and other sensitive information.

Irrelevant

8. Please run the commands with most verbose logging by adding the -v 10 flag.
Paste the logs into this report, or in a gist and provide the gist link here.

I0213 14:25:54.779621   34407 factory.go:68] state store file:///tmp/kops-state

State Store: Invalid value: "file:///tmp/kops-state": Unable to read state store.
Please use a valid state store when setting --state or KOPS_STATE_STORE env var.
For example, a valid value follows the format s3://<bucket>.
Trailing slash will be trimmed.

9. Anything else do we need to know?

The documentation specifically claims that local filesystem state storage is supported with the file:// protocol.

The bug was triggered when attempting to build a CI workflow around:

  1. sync remote S3 state bucket to a local directory
  2. change .spec.configBase to refer to the local directory
  3. run kops replace -f <candidate.yaml> --state file:///path/to/local/state/dir
  4. run kops update cluster <cluster_name> --state file:///path/to/local/state/dir

In a CI workflow, this would allow us to preview (for example, during a pull request) how a kops update cluster would run, without touching the actual remote S3 state bucket (from running kops replace).

@ari-becker

This comment has been minimized.

Copy link
Author

@ari-becker ari-becker commented Feb 13, 2019

Found the PR that introduced the documentation that claimed that filesystem state stores were supported. Before that, code and documentation were in sync about filesystem state stores being unsupported.

Are filesystem state stores supported or not?

@jgdef-tulip

This comment has been minimized.

Copy link

@jgdef-tulip jgdef-tulip commented Mar 4, 2019

I've hit the same issue w/ kops version Version 1.11.1 (git-0f2aa8d30)

@lieut-data

This comment has been minimized.

Copy link

@lieut-data lieut-data commented Mar 26, 2019

Also running into this issue, whilst trying to wrap kops as part of a larger deployment tool.

@berendt

This comment has been minimized.

Copy link

@berendt berendt commented Apr 15, 2019

Tested with version 1.14.0-alpha.1 (git-ab68aa2d2). It doesn't work there either.

@objectiveous

This comment has been minimized.

Copy link

@objectiveous objectiveous commented May 8, 2019

Likewise. I got bit by this... unfortunately.

@caioaao

This comment has been minimized.

Copy link

@caioaao caioaao commented Jun 7, 2019

Reproduced in 1.12.1 (git-e1c317f9c)

@jayunit100

This comment has been minimized.

Copy link
Member

@jayunit100 jayunit100 commented Jun 21, 2019

So, kops state local doesnt work ? I get the same feeling, but not sure, b/c i dont see any instructions on how to use it (i.e. should i make a directory or will it mkdir -p for me..)

I tried this..


➜   kops create cluster --name=jay

State Store: Invalid value: "file:///tmp/kops": Unable to read state store.
Please use a valid state store when setting --state or KOPS_STATE_STORE env var.
For example, a valid value follows the format s3://<bucket>.
Trailing slash will be trimmed.
➜  cat ~/.kops/config 
kops_state_store: file:///tmp/kops
@joshuaganger

This comment has been minimized.

Copy link

@joshuaganger joshuaganger commented Jun 21, 2019

Issue still present in 1.12.2

`[root@kube1 tmp]# kops version
Version 1.12.2 (git-3fc9bc486)
[root@kube1 tmp]# kops upgrade cluster localhost --state=file:///tmp/test

State Store: Invalid value: "file:///tmp/test": Unable to read state store.
Please use a valid state store when setting --state or KOPS_STATE_STORE env var.
For example, a valid value follows the format s3://.
Trailing slash will be trimmed.`

@qrilka

This comment has been minimized.

Copy link

@qrilka qrilka commented Jul 4, 2019

The docs https://github.com/kubernetes/kops/blob/master/docs/state.md list many supported state stores but the source code looks like SSH, local FS and MemFS are explicitly not allowed

@fejta-bot

This comment has been minimized.

Copy link

@fejta-bot fejta-bot commented Oct 2, 2019

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@ari-becker

This comment has been minimized.

Copy link
Author

@ari-becker ari-becker commented Oct 5, 2019

/remove-lifecycle stale

@elephant3

This comment has been minimized.

Copy link

@elephant3 elephant3 commented Nov 7, 2019

Same in kops 1.14.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
You can’t perform that action at this time.