Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow disabling warm pool by setting WarmPool.MaxSize to 0 #11316

Merged
merged 1 commit into from Apr 25, 2021
Merged

Allow disabling warm pool by setting WarmPool.MaxSize to 0 #11316

merged 1 commit into from Apr 25, 2021

Conversation

johngmyers
Copy link
Member

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 24, 2021
@k8s-ci-robot k8s-ci-robot added area/api area/nodeup area/provider/aws Issues or PRs related to aws provider labels Apr 24, 2021
@johngmyers
Copy link
Member Author

/assign olemarkus

@olemarkus
Copy link
Member

What is the use case for this? Perhaps if one wants to keep the struct around, but disable the pool, the standard enabled flag would be better?

@johngmyers
Copy link
Member Author

This would allow us to add a warmPool struct at cluster level, providing defaults. Much like we do for rollingUpdate.

olemarkus
olemarkus approved these changes Apr 25, 2021
View reviewed changes
Copy link
Member

@olemarkus olemarkus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 25, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: olemarkus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 25, 2021
@k8s-ci-robot k8s-ci-robot merged commit fb39ddd into kubernetes:master Apr 25, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Apr 25, 2021
@johngmyers johngmyers deleted the warm-enabled branch April 25, 2021 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olemarkus olemarkus olemarkus approved these changes

@joshbranham joshbranham Awaiting requested review from joshbranham

@mikesplain mikesplain Awaiting requested review from mikesplain

Assignees

@olemarkus olemarkus

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/api area/nodeup area/provider/aws Issues or PRs related to aws provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@johngmyers @olemarkus @k8s-ci-robot