Use kubernetes.default for OIDC discovery in gossip clusters #11470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/hold
olemarkus
approved these changes
May 12, 2021
k8s-ci-robot
added
lgtm
|
/assign @johngmyers |
|
Does the |
It doesn't make sense to use a gossip hostname as the discovery url because it wont be resolveable. For gossip clusters that dont provide a public VFS store, we can at least use kubernetes.default for internal oidc usage.
k8s-ci-robot
added
size/XS
|
Good point, I've updated this to only affect gossip clusters |
johngmyers
approved these changes
May 12, 2021
k8s-ci-robot
added
the
lgtm
|
An integration test would not be amiss. |
k8s-ci-robot
added
size/XXL
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
johngmyers
approved these changes
May 12, 2021
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johngmyers, olemarkus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It doesn't make sense to use a gossip hostname as the discovery url because it wont be resolveable.
For gossip clusters that dont provide a public VFS store, we can at least use kubernetes.default for internal oidc usage.
the goal of this is to fix the oidc tests for the e2e prow jobs that use gossip clusters:
https://testgrid.k8s.io/kops-gce#kops-gce-kubetest2&show-stale-tests=
https://testgrid.k8s.io/kops-misc#e2e-kops-do-calico&show-stale-tests=
slack thread: https://kubernetes.slack.com/archives/C8MKE2G5P/p1620837506354700
/hold for feedback