New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move asset copying out of apply_cluster #11700
Conversation
fda4495
to
2ef33cf
Compare
I'm wondering if we should announce the deprecation of the assets phase in the 1.21 release notes. This will also need mentioning in the 1.22 release notes, and ideally have documentation that walks through the process of how to use |
There's nothing a user could do with such a deprecation notice. The feature isn't going away; the command to invoke it is just changing. My documentation PR #11654 is pending review, so I can't update it in this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True, but I think the 1.22 release notes should still mention the move of functionality. I'm fine with that being in a followup PR
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rifelpet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Removes the
assets
phase, moving the functionality to the newkops get assets --copy
flag.