Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move asset copying out of apply_cluster #11700

Merged
merged 1 commit into from Jun 6, 2021

Conversation

johngmyers
Copy link
Member

Removes the assets phase, moving the functionality to the new kops get assets --copy flag.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 6, 2021
@k8s-ci-robot k8s-ci-robot added area/nodeup area/provider/aws Issues or PRs related to aws provider area/rolling-update labels Jun 6, 2021
@johngmyers johngmyers force-pushed the copy-assets branch 2 times, most recently from fda4495 to 2ef33cf Compare June 6, 2021 04:17
@rifelpet
Copy link
Member

rifelpet commented Jun 6, 2021

I'm wondering if we should announce the deprecation of the assets phase in the 1.21 release notes.

This will also need mentioning in the 1.22 release notes, and ideally have documentation that walks through the process of how to use get assets --copy but that can be in a followup PR.

@johngmyers
Copy link
Member Author

There's nothing a user could do with such a deprecation notice. The feature isn't going away; the command to invoke it is just changing.

My documentation PR #11654 is pending review, so I can't update it in this PR.

Copy link
Member

@rifelpet rifelpet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, but I think the 1.22 release notes should still mention the move of functionality. I'm fine with that being in a followup PR

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 6, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 6, 2021
@k8s-ci-robot k8s-ci-robot merged commit 2d86a85 into kubernetes:master Jun 6, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Jun 6, 2021
@johngmyers johngmyers deleted the copy-assets branch June 7, 2021 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/documentation area/nodeup area/provider/aws Issues or PRs related to aws provider area/rolling-update cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants