Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support AWS LB access log configuration in cluster spec #12067

Merged
merged 4 commits into from Aug 25, 2021
Merged

Support AWS LB access log configuration in cluster spec #12067

merged 4 commits into from Aug 25, 2021

Conversation

h3poteto
Copy link
Contributor

@h3poteto h3poteto commented Jul 29, 2021 •
edited

Refs: #11608

I added AccessLog in cluster spec to configure LB access log for API load balancer.

In ClassicLoadBalancer, access log configuration already exists, so I enable the configuration.
In NetworkLoadBalancer, access log configuration does not exist, so I add the configuration and pass the parameters when creating LB.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 29, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @h3poteto. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 29, 2021
@k8s-ci-robot k8s-ci-robot added area/api area/provider/aws Issues or PRs related to aws provider labels Jul 29, 2021
@h3poteto h3poteto marked this pull request as ready for review July 29, 2021 14:00
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 29, 2021
@rifelpet
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 29, 2021
johngmyers
johngmyers requested changes Jul 29, 2021
View reviewed changes
Copy link
Member

@johngmyers johngmyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this might not support turning off access logs. Have you tested that?

pkg/apis/kops/cluster.go Outdated Show resolved Hide resolved
pkg/apis/kops/cluster.go Outdated Show resolved Hide resolved
pkg/apis/kops/cluster.go Outdated Show resolved Hide resolved
pkg/apis/kops/cluster.go Outdated Show resolved Hide resolved
@h3poteto
Copy link
Contributor Author

@johngmyers If you do not specify the access log from the beginning, it will not be created. I tested it.
But if you want to delete the access log once set, I have not tested it yet. I will confirm it.

@rifelpet
Copy link
Member

Please add example values to this integration test: https://github.com/kubernetes/kops/tree/master/tests/integration/update_cluster/complex

update the two manifests in in-*.yaml and run ./hack/update-expected.sh to update the kubernetes.tf file in that same directory.

@h3poteto h3poteto force-pushed the iss-11608 branch 3 times, most recently from b52885d to 6d746b4 Compare August 3, 2021 12:34
@h3poteto
Copy link
Contributor Author

h3poteto commented Aug 3, 2021

@johngmyers I fixed it to turn off access log.
2fd69ba

@h3poteto
Copy link
Contributor Author

h3poteto commented Aug 3, 2021

@rifelpet Thank you. I added.
6d746b4

@allen-mun
Copy link

@rifelpet @h3poteto

Any progress on this? Looks like another review is needed from the maintainers.

@h3poteto
Copy link
Contributor Author

Nothing, I'm waiting for review.

rifelpet
rifelpet reviewed Aug 24, 2021
View reviewed changes
Copy link
Member

@rifelpet rifelpet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few nits but otherwise it looks good to me overall. Perhaps others might have feedback on the new API fields.

upup/pkg/fi/cloudup/awstasks/network_load_balancer.go Outdated Show resolved Hide resolved
upup/pkg/fi/cloudup/awstasks/network_load_balancer.go Outdated Show resolved Hide resolved
upup/pkg/fi/cloudup/awstasks/classic_load_balancer.go Outdated Show resolved Hide resolved
upup/pkg/fi/cloudup/awstasks/classic_load_balancer.go Outdated Show resolved Hide resolved
@olemarkus
Copy link
Member

The API fields look good to me.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 25, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 25, 2021
@rifelpet
Copy link
Member

/retest

@rifelpet
Copy link
Member

/test pull-kops-bazel-build
/test pull-kops-bazel-test
/test pull-kops-e2e-kubernetes-aws
/test pull-kops-verify-bazel
/test pull-kops-verify-boilerplate
/test pull-kops-verify-cloudformation
/test pull-kops-verify-generated
/test pull-kops-verify-gofmt
/test pull-kops-verify-gomod
/test pull-kops-verify-govet
/test pull-kops-verify-staticcheck
/test pull-kops-verify-terraform

@rifelpet
Copy link
Member

/test pull-kops-e2e-kubernetes-aws

@k8s-ci-robot k8s-ci-robot merged commit bb38a3e into kubernetes:master Aug 25, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Aug 25, 2021
@h3poteto
Copy link
Contributor Author

Thank you!

@h3poteto h3poteto deleted the iss-11608 branch August 26, 2021 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johngmyers johngmyers johngmyers requested changes

@rifelpet rifelpet rifelpet approved these changes

@joshbranham joshbranham Awaiting requested review from joshbranham

Assignees

@rifelpet rifelpet

@johngmyers johngmyers

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/api area/provider/aws Issues or PRs related to aws provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@h3poteto @k8s-ci-robot @rifelpet @allen-mun @olemarkus @johngmyers