New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Weave to 1.8.2 and fix semantic versioning issue #1250

Merged
merged 2 commits into from Dec 24, 2016

Conversation

Projects
None yet
4 participants
@itskingori
Copy link
Member

itskingori commented Dec 23, 2016

Primarily because Weave 1.8.2 contains many bug fixes and minor improvements.

Secondly, I filed a bug (#1246) which I think this fixes ... the release notes say "fixed a bug where Kubernetes master could not contact pods". See related issue weaveworks/weave#2673 (talks about my issue) which was fixed and merged in weaveworks/weave#2683.

Update 1:

Also addresses issue #1081.


This change is Reviewable

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Dec 23, 2016

Hi @itsmrwave. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

If you have questions or suggestions related to this bot's behavior, please file an issue against the kubernetes/test-infra repository.

@justinsb

This comment has been minimized.

Copy link
Member

justinsb commented Dec 23, 2016

@k8s-bot ok to test

@justinsb

This comment has been minimized.

Copy link
Member

justinsb commented Dec 23, 2016

We can possibly also fix #1081 at this time

@itskingori

This comment has been minimized.

Copy link
Member

itskingori commented Dec 23, 2016

@chrislovecnm I took your queue from 1bbbe0b. Admittedly, I'm not sure this is the right way to do it or if it's enough.

@chrislovecnm
Copy link
Member

chrislovecnm left a comment

Just rename the file and it looks great.

@@ -23,7 +23,7 @@ spec:
hostPID: true

This comment has been minimized.

@chrislovecnm

chrislovecnm Dec 23, 2016

Member

If we could get the file names 1.8.2.yaml, it will address an open issue.

This comment has been minimized.

@itskingori
@@ -116,7 +116,7 @@ func (b *BootstrapChannelBuilder) buildManifest() (*channelsapi.Addons, map[stri

if b.cluster.Spec.Networking.Weave != nil {
key := "networking.weave"
version := "1.8.1.20161130"
version := "1.8.2.20161223"

This comment has been minimized.

@chrislovecnm

chrislovecnm Dec 23, 2016

Member

Again we rename the file.

This comment has been minimized.

@itskingori

@itskingori itskingori changed the title Upgrade Weave to 1.8.2 Upgrade Weave to 1.8.2 and fix semantic versioning issue Dec 24, 2016

@chrislovecnm
Copy link
Member

chrislovecnm left a comment

LGTM - waiting on e2e

@itskingori

This comment has been minimized.

Copy link
Member

itskingori commented Dec 24, 2016

@chrislovecnm Looks like we're good to go. Looking forward to giving this a go.

@chrislovecnm chrislovecnm merged commit 49a0ed4 into kubernetes:master Dec 24, 2016

3 checks passed

Jenkins Kubernetes AWS e2e Build succeeded.
Details
cla/linuxfoundation itsmrwave authorized
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@itskingori itskingori deleted the itskingori:upgrade_kops_182 branch Dec 24, 2016

@itskingori

This comment has been minimized.

Copy link
Member

itskingori commented Dec 24, 2016

I'm glad to report that an unintentional upside to this change is that I am now getting proper logs from Weave. You can check for yourself using these commands (unlike what I was getting before, which made it it difficult to debug what weave is doing) ... 👇

Check 'weave-net' pod 'weave-npc' container logs:

$ for i in $(kubectl get pods --all-namespaces | grep weave-net | awk '{print $2}'); \
do \
echo "=> '$i' pod, 'weave-npc' container"; \
kubectl logs --namespace="kube-system" --container="weave-npc" $i; \
done

Check 'weave-net' pod 'weave' container logs:

$ for i in $(kubectl get pods --all-namespaces | grep weave-net | awk '{print $2}'); \
do \
echo "=> '$i' pod, 'weave' container"; \
kubectl logs --namespace="kube-system" --container="weave" $i; \
done
@chrislovecnm

This comment has been minimized.

Copy link
Member

chrislovecnm commented Dec 24, 2016

Can we get this into an issue? Good for debugging. Have you opened an issue with weave?

@itskingori

This comment has been minimized.

Copy link
Member

itskingori commented Dec 24, 2016

@chrislovecnm I don't think we need to (see weaveworks/weave#2673) and they fixed it in 1.8.2 (see weaveworks/weave#2683).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment