Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit GCE tag for role to 63 chars #13866

Merged
merged 1 commit into from Jun 24, 2022

Conversation

hakman
Copy link
Member

@hakman hakman commented Jun 24, 2022

Some tests still fail:
https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/e2e-kops-grid-gce-calico-u2004-k22-containerd/1540027335678365696

W0623 17:44:09.192151    6112 executor.go:139] error running task "FirewallRule/master-to-master-e2e-e2e-kops-grid-gce-calico-u2004-k22--1m2qc6" (9m46s remaining to succeed): error creating FirewallRule: googleapi: Error 400: Invalid value for field 'resource.sourceTags[0]': 'e2e-e2e-kops-grid-gce-calico-u2004-k22-containerd-k8s-local-k8s-io-role-master'. Must be a match of regex '(?:[a-z](?:[-a-z0-9]{0,61}[a-z0-9])?)'
More details:
Reason: invalid, Message: Invalid value for field 'resource.sourceTags[0]': 'e2e-e2e-kops-grid-gce-calico-u2004-k22-containerd-k8s-local-k8s-io-role-master'. Must be a match of regex '(?:[a-z](?:[-a-z0-9]{0,61}[a-z0-9])?)'
Reason: invalid, Message: Invalid value for field 'resource.targetTags[0]': 'e2e-e2e-kops-grid-gce-calico-u2004-k22-containerd-k8s-local-k8s-io-role-master'. Must be a match of regex '(?:[a-z](?:[-a-z0-9]{0,61}[a-z0-9])?)'

/cc @rifelpet @justinsb

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/provider/gcp Issues or PRs related to gcp provider labels Jun 24, 2022
@hakman
Copy link
Member Author

hakman commented Jun 24, 2022

/test pull-kops-e2e-k8s-gce

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 24, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 24, 2022
@k8s-ci-robot k8s-ci-robot merged commit eaec6e3 into kubernetes:master Jun 24, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Jun 24, 2022
@hakman hakman deleted the gce_limit_tag_for_role branch June 24, 2022 15:36
k8s-ci-robot added a commit that referenced this pull request Jun 24, 2022
…-upstream-release-1.24

Automated cherry pick of #13866: Limit GCE tag for role to 63 chars
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/gcp Issues or PRs related to gcp provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants