Move more networking settings into nodeup.Config #15016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
johngmyers
force-pushed
the
nodeup-network2
branch
from
ef1dc8d
to
69f0afa
Compare
hakman
reviewed
Jan 18, 2023
Comment on lines
+67
to
+70
| // UseCiliumEtcd is true when a Cilium etcd cluster is present. | ||
| UseCiliumEtcd bool `json:",omitempty"` | ||
| // UsesKubenet specifies that the CNI is derived from Kubenet. | ||
| UsesKubenet bool `json:",omitempty"` |
There was a problem hiding this comment.
Should we be consistent with Use vs Uses?
There was a problem hiding this comment.
I was being consistent with the existing components.UsesKubenet().
hakman
approved these changes
Jan 18, 2023
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass. This bot retests PRs for certain kubernetes repos according to the following rules:
You can:
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.