Update some readme's #2031
Update some readme's #2031
Conversation
|
Hi @anandkumarpatel. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
k8s-ci-robot
added
the
cncf-cla: yes
|
The first two changes look good, but I think you're running an older version of kops. At least the |
docs/aws.md
Outdated
| @@ -182,7 +182,7 @@ Kops by default will assume that the NS records created above are publicly avail | |||
| Note: There is a DNS flag that can be configured if you plan on using private DNS records | |||
|
|
|||
| ``` | |||
| kops create cluster --dns private $NAME | |||
| kops create cluster --dns-zone private $NAME | |||
docs/aws.md
Outdated
| Also kops ships with a handy validation tool that can be ran to ensure your cluster is working as expected. | ||
|
|
||
| ```bash | ||
| kops validate cluster |
docs/run_in_existing_vpc.md
Outdated
| @@ -12,7 +12,7 @@ export CLUSTER_NAME=<sharedvpc.mydomain.com> | |||
| export VPC_ID=vpc-12345678 # replace with your VPC id | |||
| export NETWORK_CIDR=10.100.0.0/16 # replace with the cidr for the VPC ${VPC_ID} | |||
|
|
|||
| kops create cluster --zones=us-east-1b --name=${CLUSTER_NAME} --vpc=${VPC_ID} | |||
| kops create cluster --zones=us-east-1b --name=${CLUSTER_NAME} --vpc=${VPC_ID} --network-cidr=${NETWORK_CIDR} | |||
|
ahh I see, I am using kops that ships with brew. Will update and try again. |
|
@anandkumarpatel do you want to pursue this PR? Might be easier to close & submit a new one... PS Thank you for contributing either way :-) |
|
@justinsb just merged with master and it looks like most of my changes were already fixed :) I just have a small nit I updated now. |
|
@k8s-bot ok to test |
This change is