Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo instance group ->"InstanceGroup" #4621

Merged
merged 1 commit into from Mar 10, 2018
Merged

Typo instance group ->"InstanceGroup" #4621

merged 1 commit into from Mar 10, 2018

Conversation

AdamDang
Copy link
Contributor

@AdamDang AdamDang commented Mar 9, 2018

"InstanceGroup" is written as "instance group", "instancegroup" and "InstanceGroup" in this doc.
It's a kops model, so needs to be written in same way.

@AdamDang
Typo instance group ->"InstanceGroup"
3970776 
"InstanceGroup" is written as "instance group", "instancegroup" and "InstanceGroup" in this doc.
It's a kops model, so needs to be written in same way.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 9, 2018
@justinsb
Copy link
Member

justinsb commented Mar 9, 2018

/lgtm

Thanks @AdamDang

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 9, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AdamDang, justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 9, 2018
@chrislovecnm
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 10, 2018
@k8s-ci-robot k8s-ci-robot merged commit f696899 into kubernetes:master Mar 10, 2018
@AdamDang AdamDang deleted the patch-7 branch March 18, 2018 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@justinsb justinsb

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@AdamDang @justinsb @k8s-ci-robot @chrislovecnm