Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement subnet task for OpenStack platform #4945

Merged
merged 1 commit into from Apr 9, 2018
Merged

implement subnet task for OpenStack platform #4945

merged 1 commit into from Apr 9, 2018

Conversation

zengchen1024
Copy link
Contributor

@zengchen1024 zengchen1024 commented Apr 9, 2018 •
edited

This is part of work of issue (#3566)

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 9, 2018
justinsb
justinsb reviewed Apr 9, 2018
View reviewed changes
upup/pkg/fi/cloudup/openstacktasks/subnet.go
Name: fi.StringValue(s.Name),
NetworkID: fi.StringValue(s.Network.ID),
CIDR: fi.StringValue(s.CIDR),
EnableDHCP: fi.Bool(true),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not 100% familiar with the Neutron API, but this seems like it might be selecting too narrowly. Typically you want to find the network by one piece of information (the most specific you can), and then you return the values that you found. And - for example - if we want DHCP to be enabled, we would set that as a field on Subnet, we would return the actual value we found, and then RenderOpenstack would be responsible for setting the DHCP value if it was changed.

But ... not sure about this, so going to LGTM anyway!

@justinsb
Copy link
Member

justinsb commented Apr 9, 2018

/ok-to-test

/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 9, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb, zengchen1024

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 9, 2018
@k8s-ci-robot k8s-ci-robot merged commit 921e9ae into kubernetes:master Apr 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinsb justinsb justinsb left review comments

Assignees

@justinsb justinsb

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zengchen1024 @justinsb @k8s-ci-robot