Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
set default GracePeriodSeconds to -1 when draining nodes #5143
the default value for GracePeriodSeconds in kubectl drain is set to -1, therefore the drain node gives pod time to terminate gracefully, but through kops its set to use default int value 0, and therefore pods are terminated immediately.
disclaimer: I've not tested it, and plan to test it tonight by triggering a rolling update on one IG for my cluster, but theoretically this seems to be the reason why our pods are not getting any graceful termination time as reported by our users.
Please let me know if this does not make sense.
thanks for looking into it.
This is as per documentation here: https://github.com/kubernetes/kubernetes/blob/c9591ee6cb13f2f0e6c7431873f0ac2c1a559c37/pkg/kubectl/cmd/drain.go#L223
and its usage here:
Please let me know if I should get more information on this.
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing