Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documentation about targetGroupArn key #6611

Merged
merged 1 commit into from Mar 15, 2019

Conversation

Projects
None yet
4 participants
@phyrog
Copy link
Contributor

phyrog commented Mar 13, 2019

The key needs to be named targetGroupArn instead of targetGroupARN.

See also #5791

Fix documentation about targetGroupArn key
The key needs to be named `targetGroupArn` instead of `targetGroupARN`.
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Mar 13, 2019

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Mar 13, 2019

Hi @phyrog. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@phyrog

This comment has been minimized.

Copy link
Contributor Author

phyrog commented Mar 13, 2019

CLA is signed

@rifelpet

This comment has been minimized.

Copy link
Member

rifelpet commented Mar 13, 2019

Thanks for the docs fix!

TargetGroupARN *string `json:"targetGroupArn,omitempty"`

/ok-to-test

@justinsb

This comment has been minimized.

Copy link
Member

justinsb commented Mar 14, 2019

Thanks @phyrog

/approve
/lgtm

/retest

(Travis just timed out on the OSX builder)

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Mar 14, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb, phyrog

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@phyrog

This comment has been minimized.

Copy link
Contributor Author

phyrog commented Mar 14, 2019

Timed out again

/retest

Edit: Meh, doesn't seem to work for me :)

@k8s-ci-robot k8s-ci-robot merged commit b21e47e into kubernetes:master Mar 15, 2019

11 checks passed

cla/linuxfoundation phyrog authorized
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
pull-kops-bazel-build Job succeeded.
Details
pull-kops-bazel-test Job succeeded.
Details
pull-kops-e2e-kubernetes-aws Job succeeded.
Details
pull-kops-verify-bazel Job succeeded.
Details
pull-kops-verify-boilerplate Job succeeded.
Details
pull-kops-verify-gofmt Job succeeded.
Details
pull-kops-verify-govet Job succeeded.
Details
pull-kops-verify-packages Job succeeded.
Details
tide In merge pool.
Details

@phyrog phyrog deleted the phyrog:patch-1 branch Mar 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.