Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't panic when deleting instancegroups #7000

Merged
merged 1 commit into from May 16, 2019

Conversation

Projects
None yet
3 participants
@justinsb
Copy link
Member

commented May 16, 2019

Issue #6999

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented May 16, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zetaab

This comment has been minimized.

Copy link
Member

commented May 16, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label May 16, 2019

k8s-ci-robot added a commit that referenced this pull request May 16, 2019

@k8s-ci-robot k8s-ci-robot merged commit 4ca73f8 into kubernetes:master May 16, 2019

11 checks passed

cla/linuxfoundation justinsb authorized
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
pull-kops-bazel-build Job succeeded.
Details
pull-kops-bazel-test Job succeeded.
Details
pull-kops-e2e-kubernetes-aws Job succeeded.
Details
pull-kops-verify-bazel Job succeeded.
Details
pull-kops-verify-boilerplate Job succeeded.
Details
pull-kops-verify-gofmt Job succeeded.
Details
pull-kops-verify-govet Job succeeded.
Details
pull-kops-verify-packages Job succeeded.
Details
tide In merge pool.
Details

k8s-ci-robot added a commit that referenced this pull request May 17, 2019

Merge pull request #7019 from mikesplain/automated-cherry-pick-of-#6951-
#7000-origin-release-1.14

Automated cherry pick of #6951: LaunchTemplate - support for deletion of instance group which #7000: Don't panic when deleting instancegroups

k8s-ci-robot added a commit that referenced this pull request May 17, 2019

Merge pull request #7018 from mikesplain/automated-cherry-pick-of-#6951-
#7000-origin-release-1.13

Automated cherry pick of #6951: LaunchTemplate - support for deletion of instance group which #7000: Don't panic when deleting instancegroups
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.